Restore the type squares in the results grids#1028
Closed
MDA2AV wants to merge 1 commit into
Closed
Conversation
#1017 removed the infrastructure tier and took the other four type colours with it. All five lived on a single line: .tsq-flagship{...} .tsq-emerging{...} .tsq-experimental{...} .tsq-engine{...} .tsq-infrastructure{...} so deleting "the infrastructure badge rule" deleted the line. Every other removal in that commit was correctly scoped -- the filter pill, the tooltip, the abbreviation, the localStorage whitelist, the isScored branch and .b-infrastructure were all infrastructure-only. This one wasn't, because the line was shared. .tsq kept its width, height and border-radius but lost every background, so each square rendered as a 10x10 transparent box. Both grid renderers still emit `class="tsq tsq-<type>"`, so nothing was wrong with the markup -- there was simply no colour to paint. The yellow tuned ring kept showing because it is a ::after with its own background, which is why the squares looked like they vanished from beside an otherwise intact marker. Restores the four surviving colours at their original values, unchanged and still matching the .b-* badge and filter-pill palette (flagship #2e9e6a, emerging #3b73c4, experimental #d98e2b, engine #cb5f51). One rule per line now, so removing a tier can't silently take the others again. Verified in headless Chrome against the real data files, on this branch and on main for comparison: main this branch flagship + emerging 51/51 transparent 0/51, correct colours engine 26/26 transparent 0/26, rgb(203,95,81) experimental 2/2 transparent 0/2, rgb(217,142,43) Checked in both grid renderers (composite table and profile grid) and in dark mode; the tuned ring still renders.
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The little type squares next to every framework in the results grids stopped rendering after #1017.
Cause
All five type colours lived on one line:
so deleting "the infrastructure badge rule" deleted the whole line. Every other removal in #1017 was correctly scoped — the filter pill, the tooltip, the abbreviation, the localStorage whitelist, the
isScoredbranch and.b-infrastructurewere all infrastructure-only. This one wasn't, because the line was shared..tsqkept itswidth,heightandborder-radiusbut lost everybackground, so each square rendered as a 10×10 transparent box. Both grid renderers still emitclass="tsq tsq-<type>"— the markup was fine, there was just no colour to paint. The yellow tuned ring kept showing because it's an::afterwith its own background, which is exactly why the squares looked like they vanished from beside an otherwise intact marker.Fix
Restores the four surviving colours at their original values — unchanged, and still matching the
.b-*badge and filter-pill palette:#2e9e6a#3b73c4#d98e2b#cb5f51One rule per line now, so removing a tier can't silently take the others again.
Verification
Headless Chrome against the real
data.js/docs.js, run on this branch and onmainfor comparison:mainrgb(203,95,81)rgb(217,142,43)Checked in both grid renderers (composite table and profile grid) and in dark mode; the tuned ring still renders.
🤖 Generated with Claude Code