Skip to content

Restore the type squares in the results grids#1028

Closed
MDA2AV wants to merge 1 commit into
mainfrom
fix-type-squares
Closed

Restore the type squares in the results grids#1028
MDA2AV wants to merge 1 commit into
mainfrom
fix-type-squares

Conversation

@MDA2AV

@MDA2AV MDA2AV commented Jul 24, 2026

Copy link
Copy Markdown
Owner

The little type squares next to every framework in the results grids stopped rendering after #1017.

Cause

All five type colours lived on one line:

.tsq-flagship{…} .tsq-emerging{…} .tsq-experimental{…} .tsq-engine{…} .tsq-infrastructure{…}

so deleting "the infrastructure badge rule" deleted the whole line. Every other removal in #1017 was correctly scoped — the filter pill, the tooltip, the abbreviation, the localStorage whitelist, the isScored branch and .b-infrastructure were all infrastructure-only. This one wasn't, because the line was shared.

.tsq kept its width, height and border-radius but lost every background, so each square rendered as a 10×10 transparent box. Both grid renderers still emit class="tsq tsq-<type>" — the markup was fine, there was just no colour to paint. The yellow tuned ring kept showing because it's an ::after with its own background, which is exactly why the squares looked like they vanished from beside an otherwise intact marker.

Fix

Restores the four surviving colours at their original values — unchanged, and still matching the .b-* badge and filter-pill palette:

type colour
flagship #2e9e6a
emerging #3b73c4
experimental #d98e2b
engine #cb5f51

One rule per line now, so removing a tier can't silently take the others again.

Verification

Headless Chrome against the real data.js/docs.js, run on this branch and on main for comparison:

filter main this branch
flagship + emerging 51/51 transparent 0/51, correct colours
engine 26/26 transparent 0/26, rgb(203,95,81)
experimental 2/2 transparent 0/2, rgb(217,142,43)

Checked in both grid renderers (composite table and profile grid) and in dark mode; the tuned ring still renders.

🤖 Generated with Claude Code

#1017 removed the infrastructure tier and took the other four type colours
with it. All five lived on a single line:

  .tsq-flagship{...} .tsq-emerging{...} .tsq-experimental{...}
  .tsq-engine{...} .tsq-infrastructure{...}

so deleting "the infrastructure badge rule" deleted the line. Every other
removal in that commit was correctly scoped -- the filter pill, the tooltip,
the abbreviation, the localStorage whitelist, the isScored branch and
.b-infrastructure were all infrastructure-only. This one wasn't, because
the line was shared.

.tsq kept its width, height and border-radius but lost every background, so
each square rendered as a 10x10 transparent box. Both grid renderers still
emit `class="tsq tsq-<type>"`, so nothing was wrong with the markup -- there
was simply no colour to paint. The yellow tuned ring kept showing because it
is a ::after with its own background, which is why the squares looked like
they vanished from beside an otherwise intact marker.

Restores the four surviving colours at their original values, unchanged and
still matching the .b-* badge and filter-pill palette (flagship #2e9e6a,
emerging #3b73c4, experimental #d98e2b, engine #cb5f51). One rule per line
now, so removing a tier can't silently take the others again.

Verified in headless Chrome against the real data files, on this branch and
on main for comparison:

                              main            this branch
  flagship + emerging     51/51 transparent   0/51, correct colours
  engine                  26/26 transparent   0/26, rgb(203,95,81)
  experimental              2/2 transparent   0/2,  rgb(217,142,43)

Checked in both grid renderers (composite table and profile grid) and in
dark mode; the tuned ring still renders.
@MDA2AV

MDA2AV commented Jul 24, 2026

Copy link
Copy Markdown
Owner Author

Closing as a duplicate — this is already in main via #1025 (squash-merged as 36938032). I re-created it from the same branch after GitHub's PR API recovered, not realising you'd already opened and merged it; --author @me hid #1025 from my listing.

@MDA2AV MDA2AV closed this Jul 24, 2026
@MDA2AV
MDA2AV deleted the fix-type-squares branch July 24, 2026 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant