Repository navigation
Conversation
Supersedes-rebase of victorator's PR MCRcortex#708 (cursor/fix-old-world-blockstate-migration-0e17), which no longer applies after the October remapper commits. Same design: stamp data_version on save, datafix unversioned {Name,Properties} from 2531, failed decodes stay air in memory without rewriting stored bytes, resave iterates by id. Adapted to HEAD's fastIterator loop style. All 4 MapperBlockStateMigrationTest tests pass.
Author
|
Closing per maintainer policy in #614 (no AI-made PRs will be merged) — my miss for not checking before opening. Leaving the branch visible in case the rebase itself is useful to @victorator for #708; no hard feelings either way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersede-rebase of #708 by @victorator (cursor/fix-old-world-blockstate-migration-0e17), which no longer applies after the October remapper commits on 263 (
git apply --checkfails on Mapper.java).Same design, no behavior change vs #708: stamp
data_versionon save; datafix unversioned {Name, Properties} compounds from 2531 (not 0, avoiding the 1.13 flattener and RedstoneWireConnectionsFix); failed decodes stay air in memory without touching stored bytes (drops the random-block substitution); forceResaveStates iterates by id and skips all air. Adapted to HEAD's fastIterator loop style only.Verification: all 4 MapperBlockStateMigrationTest tests pass (headless, JUnit), full compile green, client jar builds.
Happy to close this in favor of a rebase by the original author — just wanted the fix testable against current 263. Full credit to @victorator for the design, tests, and root-cause analysis.