Repository navigation
Fix grass block sides appearing white with custom resource packs (fixes #203, #373) - #704
Open
anton-sjoberg wants to merge 4 commits into
Open
anton-sjoberg wants to merge 4 commits into
anton-sjoberg wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fixes #203
Fixes #373
This PR resolves issues where grass block side faces render white or display white/light-colored bands when using custom resource packs (e.g., Whimscape, Faithful) or at distant LOD mip levels.
Problem & Root Cause
Previously, quads.frag attempted to detect tinted grass overlay pixels using a heuristic grayscale test:
glsl if (abs(tintTest.r - tintTest.g) < 0.02f && abs(tintTest.g - tintTest.b) < 0.02f) { doTint = true; }This heuristic suffered from multiple failure modes:
Solution
eedsAlphaDiscard = false for partial-tint faces so dirt pixels are never discarded.
glsl colour.rgb *= mix(vec3(1.0), tintRGB, colour.a);