Repository navigation
Fix viewport material update identity and explain enhanced subdivision creases - #1110
Closed
FreeCAD-Nut wants to merge 2 commits into
Closed
FreeCAD-Nut wants to merge 2 commits into
FreeCAD-Nut wants to merge 2 commits into
Conversation
Member
|
Hi, About the tooltips: The original description referred to dihedral angles, not the normals. Hence this is just a rewording and I would not approve such changes - unless there is a specific difference w.r.t. the underlying code (e.g. conventions assumed in the evaluation, but I see no such reference here). The functional change Can you provide an example .blend-file for us to reproduce the issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Viewport material updates can export an evaluated material with different child-node identities from the original datablock used during initial export. In a Blender 5.2.3 subdivision/displacement scene this led to references to undefined named objects. Pass
mat.originaltomaterial.convertduring cache updates so initial and incremental exports use consistent identities.Also describe Enhanced subdivision and correct the sharpness tooltip: an edge is classified as sharp when the angle between adjacent face normals is greater than the threshold, not less.
Validation: Python syntax checked against current main. The same material-cache correction passed the local Blender 5.2.3 viewport regression with the patched LuxCore 2.11.2 renderer; displacement rendering and geometry checks also passed. This is not an exhaustive Blender-version compatibility test. Native subdivision/crease fixes are being submitted separately to LuxCore.