Skip to content

Fix viewport material update identity and explain enhanced subdivision creases - #1110

Closed
FreeCAD-Nut wants to merge 2 commits into
LuxCoreRender:mainfrom
FreeCAD-Nut:codex/material-update-subdivision
Closed

FreeCAD-Nut wants to merge 2 commits into
LuxCoreRender:mainfrom
FreeCAD-Nut:codex/material-update-subdivision

Conversation

@FreeCAD-Nut

Copy link
Copy Markdown

Viewport material updates can export an evaluated material with different child-node identities from the original datablock used during initial export. In a Blender 5.2.3 subdivision/displacement scene this led to references to undefined named objects. Pass mat.original to material.convert during cache updates so initial and incremental exports use consistent identities.

Also describe Enhanced subdivision and correct the sharpness tooltip: an edge is classified as sharp when the angle between adjacent face normals is greater than the threshold, not less.

Validation: Python syntax checked against current main. The same material-cache correction passed the local Blender 5.2.3 viewport regression with the patched LuxCore 2.11.2 renderer; displacement rendering and geometry checks also passed. This is not an exhaustive Blender-version compatibility test. Native subdivision/crease fixes are being submitted separately to LuxCore.

@CodeFHD

CodeFHD commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Hi,

About the tooltips: The original description referred to dihedral angles, not the normals. Hence this is just a rewording and I would not approve such changes - unless there is a specific difference w.r.t. the underlying code (e.g. conventions assumed in the evaluation, but I see no such reference here).

The functional change mat.original vs mat is simple in terms of the code change, but still should be evaluated if it indeed is a correct general fix, or just a workaround for an issue in specific scenarios.

Can you provide an example .blend-file for us to reproduce the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants