Repository navigation
Conversation
Support for the sky3 world light and sun3 sun-disc light based on the Prague Sky Model (Wilkie 2021) added to LuxCore on the feature/SkyModelWilkie2021 branch. - New "Prague Sky" world light type with visibility/altitude/groundalbedo atmosphere parameters, exported as a shared scene.pragueskymodel block - New "Prague Sun" sun light type, plus transparent sun-to-sun3 export for a sun lamp attached to a Prague Sky world - Prague Sky Model dataset path is an addon preference, validated in the UI and in the export - Sun-following viewport updates for sky3 (WorldCache), env. light cache and indirect visibility support like sky2
- Emit the Prague Sky Model dataset path and atmosphere parameters per light so a light re-parsed during a live viewport update can find the dataset (previously the sun disappeared until the viewport render was restarted) - Only re-export lights that were actually updated (moved or settings changed) instead of all lights on every viewport update, which re-created the lights in LuxCore and caused the Prague Sky Model dataset to be reloaded - Re-export the sun lamps of a Prague Sky world (attached sun and Prague Sun lamps) when the world changes, so they pick up edited atmosphere parameters like visibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the BlendLuxCore-PR corresponding to LuxCoreRender/LuxCore#748
The new sky model is exposed as a separate option next to the existing sky model.
It could be considered as an option to only show a single "Sky" option and present separate model options below that level.
The database file required by the model can be configured in the addon preferences. Again, it could be considered to provide this setting with the Sky settings itself, but it is unlikely users will switch the database often, and hence I expect it would be more of a nuisance having to configure it in each new .blend-file.