Skip to content

feat: Autoswap improvements (skip unload per model type) - #2367

Open
esolithe wants to merge 2 commits into
LostRuins:concedo_experimentalfrom
esolithe:autoswapImprovements
Open

feat: Autoswap improvements (skip unload per model type)#2367
esolithe wants to merge 2 commits into
LostRuins:concedo_experimentalfrom
esolithe:autoswapImprovements

Conversation

@esolithe

Copy link
Copy Markdown

What's new

  • Adds options to skip swapping for certain model types during autoswap, such as embedding models which may be lightweight enough to keep in memory as other stuff runs

@LostRuins

Copy link
Copy Markdown
Owner

This seems like a very janky approach. I think we can do better by making the autoswap for small models intelligent - if the model file is less than say 1gb, disqualify it from autoswap.

@henk717

henk717 commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

I prefer both approaches combined. This one gives the user the desirable flexibility while your idea is a better default.

@LostRuins

Copy link
Copy Markdown
Owner

too many single purpose flags for me tho

@esolithe

Copy link
Copy Markdown
Author

This seems like a very janky approach. I think we can do better by making the autoswap for small models intelligent - if the model file is less than say 1gb, disqualify it from autoswap.

Frankly this is more limiting to the user in my mind? Not everyone has that extra GB. Or some might have plenty more. Trying to guess every combination isn't something I would expect to automatically work well.

The flags are in a python dict so it isn't separated out within the code itself - and for a launcher those many options don't change much because a use is just ticking boxes. But if you wanted to make the argument for it singular maybe that would work? Like a list of the excluded types which translates to Boolean flags in the config / code?

@henk717

henk717 commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

One command where you specify what to pin sounds logical to me. Prevents the clutter and keeps the customizability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants