Keep workers alive on bad attachments and unreadable sources#397
Open
wuercher wants to merge 1 commit into
Open
Keep workers alive on bad attachments and unreadable sources#397wuercher wants to merge 1 commit into
wuercher wants to merge 1 commit into
Conversation
pdf2json can throw an unhandled rejection deep in image parsing (e.g. "Bits per component missing in image") that bypasses the pdfParser error events and crashes the indexing worker. As the workers run under concurrently, the crashed worker is not restarted and all indexing silently halts while emails keep being archived. - Re-enable the safety timeout in extractTextFromPdf so a hung parse resolves empty instead of leaving the promise (and the indexing job) pending forever. - Add unhandledRejection/uncaughtException guards to the indexing and ingestion workers so a single bad attachment, or an unreadable/locked source file (EACCES ReadStream error), cannot take the whole worker down. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pdf2json can throw an unhandled rejection deep in image parsing (e.g. "Bits per component missing in image") that bypasses the pdfParser error events and crashes the indexing worker. As the workers run under concurrently, the crashed worker is not restarted and all indexing silently halts while emails keep being archived.
Fixes #398