Repository navigation
Conversation
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
djwhitt
added this pull request to stack #4121
October 8, 2026 19:04
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
Depends on #4052 (
feat/enforced-clickhouse-endpoint-settings). This PR contains only the dependent O11Y-2661 change. Merge #4052 first, then retarget this PR tomain.Closes https://linear.app/supabase/issue/O11Y-2661/per-query-class-clickhouse-settings-for-logflare-endpoint-queries
Summary
query_class_settings, including a required default priority and the eight existing workload classes. Ordinary backend saves cannot change or erase policy, including through stale snapshots or backend-type changes.Validation
MIX_ENV=test ../bin/x mix cipasses: compilation, formatting, lint, security, clone ratchet, and structural checks.system.query_log.Settings, every allowlisted key under a temporaryreadonly = 2user, and rejection above server profile ceilings. Temporary users are removed and an independent cleanup audit returns no residual test users.Rollout boundaries
No production ClickHouse configuration has changed, and local checks do not establish production profile compatibility or competing-load dashboard latency. Deploy support on every instance before enabling class policy, then coordinate backend policy and the matching profile priority baseline. Do not weaken readonly/sandbox permissions to enable settings.
The existing header remains a trusted-gateway scheduling hint, not an authorization boundary. Priority does not provide tenant isolation or aggregate admission control; lower-priority work retains memory/connections while paused. Aggregate throttling (O11Y-2662) and separate API/MCP compute remain follow-ups.