Repository navigation
refactor: Clickhouse test setup and teardown - #4108
Open
msmithstubbs wants to merge 18 commits into
Open
msmithstubbs wants to merge 18 commits into
msmithstubbs wants to merge 18 commits into
Conversation
msmithstubbs
changed the title
…res modes Move FinchDefaultHttp1 pool to base_finch_pools
msmithstubbs
force-pushed
the
refactor/clickhouse-tests
branch
from
October 6, 2026 05:20
9c451b9 to
5c4a34a
Compare
msmithstubbs
commented
Oct 6, 2026
| insert(:plan, name: "Free") | ||
| {source, backend} = setup_clickhouse_test() | ||
|
|
||
| {:ok, _supervisor_pid} = ClickHouseAdaptor.start_link(backend) |
Contributor
Author
There was a problem hiding this comment.
Not needed: requests are mocked
msmithstubbs
commented
Oct 6, 2026
|
|
||
| {source, backend} = setup_clickhouse_test() | ||
|
|
||
| {:ok, supervisor_pid} = ClickHouseAdaptor.start_link(backend) |
Contributor
Author
There was a problem hiding this comment.
Removed these when just for querying as it is started lazily.
msmithstubbs
marked this pull request as ready for review
October 6, 2026 05:47
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduces repetition and tidies up some of the Clickhouse boilerplate:
Follows review of #3828 (merge it first)
Closes O11Y-2518