Profile dataloader initialization in FitLoop and update outdated docs#21776
Open
yuxin00j wants to merge 2 commits into
Open
Profile dataloader initialization in FitLoop and update outdated docs#21776yuxin00j wants to merge 2 commits into
yuxin00j wants to merge 2 commits into
Conversation
092b767 to
39ef688
Compare
zhixiangli
reviewed
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #21771
This PR addresses the issue where the PyTorch Lightning profiler fails to capture the latency spike during dataloader worker initialization and early prefetching.
Specifically, this PR:
iter(self._data_fetcher)in_FitLoop.setup_data()with the action name"setup_train_dataloader". This ensures that worker spawn and initialization times appear in the standard Fit Profiler Report.get_train_batch(which was deprecated during the 2021 loops refactor) in theAdvancedProfilerdocumentation and replaces it withsetup_train_dataloader.test_setup_train_dataloader_profiled_actionsusingBoringModelto assert that the"setup_train_dataloader"action is correctly recorded inprofiler.profiled_actions.PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist