fix: forward storage_options as kwargs in CloudParquetDir#836
Open
SAY-5 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #836 +/- ##
===================================
Coverage 81% 81%
===================================
Files 54 54
Lines 7671 7671
===================================
Hits 6186 6186
Misses 1485 1485 🚀 New features to boost your workflow:
|
deependujha
reviewed
Jun 20, 2026
deependujha
approved these changes
Jun 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes #835.
CloudParquetDirunpackedstorage_optionspositionally withfsspec.filesystem(provider, *self.storage_options), which passes the dict keys as positional arguments and raisesTypeError: filesystem() takes 1 positional argument but ... were givenwhenever a non-emptystorage_optionsis supplied (e.g. S3 credentials). Switching to**self.storage_optionsforwards them as keyword arguments, matching howlitdata/raw/indexer.pyalready callsfsspec.filesystem.Added a regression test asserting the storage options reach
fsspec.filesystemas keyword arguments.PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃