Skip to content

fix: no prints in server#707

Open
racinmat wants to merge 4 commits into
Lightning-AI:mainfrom
racinmat:prints-fix
Open

fix: no prints in server#707
racinmat wants to merge 4 commits into
Lightning-AI:mainfrom
racinmat:prints-fix

Conversation

@racinmat

@racinmat racinmat commented Jun 7, 2026

Copy link
Copy Markdown

What does this PR do?

Fixes #696, fixes #697.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
    • [nobody reacted to them.
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
    • there is nothing to update
  • Did you write any new necessary tests?
    • no, are they needed?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@racinmat

Copy link
Copy Markdown
Author

@tchaton @aniketmaurya hi, could you please take a look at this PR? Thank you.

@codecov-commenter

codecov-commenter commented Jun 22, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85%. Comparing base (aaed44c) to head (61eefe4).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #707   +/-   ##
===================================
- Coverage    85%    85%   -0%     
===================================
  Files        39     39           
  Lines      3282   3285    +3     
===================================
+ Hits       2778   2779    +1     
- Misses      504    506    +2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@racinmat

Copy link
Copy Markdown
Author

@tchaton thanks for the approval. I think both failed tests are flaky tests unrelated to my code changes, what can we do about it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

invalid ip address for windows during local debugging Print used in multiple places instead of logger

4 participants