Repository navigation
fix(ci): pass merged PR data to deploy steps through env - #527
Merged
Merged
Conversation
Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
Contributor
|
Contributor
|
🚀 Starting production deploy of site header and footer fragments... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Deploy workflow failed after merging #522 (run 41648789500) because the PR title contains an apostrophe (
Mari's). The merged PR JSON was interpolated with${{ }}inside a single-quotedecho, so the quote closed the string early and bash aborted withunexpected EOF while looking for matching '"'.This passes
steps.pr.outputs.datathrough aPR_DATAenvironment variable and reads it withjq ... <<< "$PR_DATA"in both "Comment starting deploy on PR" and "Store deployment info". Besides fixing titles with quotes, it stops PR titles from being evaluated as shell code.${PR_DATA:-null}keeps the "Store deployment info" step working when the PR lookup step is skipped (e.g.workflow_dispatch).Validated locally: the YAML parses, and
jqextracts number and title correctly from a payload containing', and returns empty values when there is no data.