Repository navigation
[stable35] fix(rejection): complete the workflow when the last pending signer rejects - #9331
Merged
Merged
Conversation
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
… stable35 Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
force-pushed
the
backport/9234/stable35
branch
from
November 2, 2026 19:00
e5d01e8 to
47cf3f4
Compare
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #9234 for LibreSign 15 (
stable35).Stable35 adaptation
The automatic backport's seven commits were incomplete: stable35 has the frozen
signature_rejectionpolicy (cancel_workflow) rather thanSignatureRejectionBehavior, and lacks the newerSignRequest::isObserver()API. They were replaced by three focused commits signed with DCO and verified cryptographically.SIGNEDonly if someone signed and every other signer either signed or rejected.Self-contained test compatibility
A fourth signed commit adds the exact four updated Behat support files from #9324: nextcloud-behat v1.6.4, its lockfile, the activity-preference step and semantic JSON policy assertions. This PR can validate independently against stable35. If #9324 merges first, these overlapping changes become part of the base.
Validation
git diff --check: passed.cb697c43a7fcfinished: 57 successful checks, 7 skipped, 0 failures. All four PHPUnit and four Behat workflow matrices passed. SQLite/PHP 8.5 ran 202 Behat scenarios (202 passed), 3,278 steps (3,278 passed), including the new rejection-after-signature regression.Merge-readiness checklist
Integration order
Review and merge #9324 first, then recheck this PR before merging. The four shared Behat support files are byte-identical between #9324 and #9331. A Git merge-tree simulation reports no conflict. No part of #9305 (all-signers-rejected behavior) is included in this backport.