Skip to content

test(e2e): use toast live region in identification-document Playwright checks - #9329

Merged
vitormattos merged 1 commit into
mainfrom
fix/playwright-id-docs-toast-aria-live-20261102
Nov 2, 2026
Merged

vitormattos merged 1 commit into
mainfrom
fix/playwright-id-docs-toast-aria-live-20261102

Conversation

@vitormattos

Copy link
Copy Markdown
Member

Problem

Playwright E2E fails in #9305 and #9234, although the identification-document upload/delete operations succeed. The test searches for role="status" when asserting Nextcloud dialogs success toasts.

The captured Playwright trace contains the toast DOM as <div class="toastify … toast-success" aria-live="polite">File was deleted.</div> with no role="status". The post-upload snapshot also shows the Delete file action, confirming that the document was uploaded.

The identical, unchanged test is present on both PR branches and main; this is not a rejection-workflow regression.

Change

Use the actual toast live-region accessibility attribute ([aria-live="polite"]) for both upload and delete success assertions in playwright/e2e/id-docs-visual.spec.ts. Keep the message checks and the persistent document-state assertions unchanged. No tests are disabled and no timeouts are increased.

Verification

The same small patch is being applied to the two affected contributor branches so their CI can rerun before this shared test fix merges into main.

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos
vitormattos requested a review from a team as a code owner November 2, 2026 16:47
@vitormattos
vitormattos merged commit 6afd372 into main Nov 2, 2026
64 of 66 checks passed
@vitormattos
vitormattos deleted the fix/playwright-id-docs-toast-aria-live-20261102 branch November 2, 2026 20:30
@vitormattos vitormattos added this to the Next Major (36) milestone Nov 6, 2026 — with ChatGPT Codex Connector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant