Repository navigation
test(e2e): use toast live region in identification-document Playwright checks - #9329
Merged
Merged
Conversation
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
deleted the
fix/playwright-id-docs-toast-aria-live-20261102
branch
November 2, 2026 20:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Playwright E2E fails in #9305 and #9234, although the identification-document upload/delete operations succeed. The test searches for
role="status"when asserting Nextcloud dialogs success toasts.The captured Playwright trace contains the toast DOM as
<div class="toastify … toast-success" aria-live="polite">File was deleted.</div>with norole="status". The post-upload snapshot also shows the Delete file action, confirming that the document was uploaded.The identical, unchanged test is present on both PR branches and
main; this is not a rejection-workflow regression.Change
Use the actual toast live-region accessibility attribute (
[aria-live="polite"]) for both upload and delete success assertions inplaywright/e2e/id-docs-visual.spec.ts. Keep the message checks and the persistent document-state assertions unchanged. No tests are disabled and no timeouts are increased.Verification
aria-live="polite"success toast with no status role.npm ci --include=dev --ignore-scripts --no-fund --no-auditpassed.npm run ts:checkpassed.eslint playwright/e2e/id-docs-visual.spec.tspassed.playwright test --list playwright/e2e/id-docs-visual.spec.tspassed (one test discovered).The same small patch is being applied to the two affected contributor branches so their CI can rerun before this shared test fix merges into
main.