Skip to content

💤 fix: Preserve Dormant Workspace Bindings - #15877

Merged
danny-avila merged 2 commits into
devfrom
danny-avila/fix-stale-workspace-history
Sep 13, 2026
Merged

danny-avila merged 2 commits into
devfrom
danny-avila/fix-stale-workspace-history

Conversation

@danny-avila

@danny-avila danny-avila commented Sep 13, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

I fixed agent duplication and version reversion so dormant historical BYOM workspace bindings remain recoverable after their attached environment is removed, while active bindings continue to fail closed against current deployment policy.

  • Preserve disabled workspace metadata during agent duplication and version restoration.
  • Resolve the effective workspace state that survives version restoration before applying active-session validation.
  • Keep the restore policy in the TypeScript workspace module and the legacy controller as a thin caller.
  • Continue validating attached environment and workspace bindings whenever restored stateful code sessions are active.
  • Cover duplicate and revert behavior for dormant preservation, explicit active rejection, and inherited active state.

Change Type

  • Bug fix (non-breaking change which fixes an issue)

Testing

  • Passed 12 focused packages/api workspace policy tests.
  • Passed four focused duplicate/revert controller tests using mongodb-memory-server.
  • Passed npx tsc --noEmit in packages/api.
  • Passed ESLint against all four changed source and test files.
  • Passed git diff --check.

Test Configuration:

  • macOS
  • Node.js v24.16.0
  • Jest with mongodb-memory-server

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in complex areas where the persistence contract is non-obvious
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes

@danny-avila

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review the current PR head 67c94ae. Confirm that this exact commit is the reviewed commit and ignore findings that apply only to earlier heads.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-13T05:33:07.558376Z 22cee84 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@danny-avila danny-avila changed the title 🧭 fix: Preserve Disabled Workspace Bindings 💤 fix: Preserve Dormant Workspace Bindings Sep 13, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 67c94ae263

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread api/server/controllers/agents/v1.js Outdated
Comment thread api/server/controllers/agents/v1.js Outdated
@danny-avila

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review the current PR head 22cee84. Confirm that this exact commit is the reviewed commit and ignore findings that apply only to earlier heads.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: 22cee849ca

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@danny-avila
danny-avila merged commit 17c7b30 into dev Sep 13, 2026
32 checks passed
@danny-avila
danny-avila deleted the danny-avila/fix-stale-workspace-history branch September 13, 2026 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant