This repository was archived by the owner on Mar 28, 2022. It is now read-only.
Static labels on Polylines, Polygons and Paths - #140
Open
dr-itz wants to merge 5 commits into
Open
Conversation
Support for static labels on a Path/Polyline/Polygon. The user can supply a LatLng in the showLabel() method. If none is specified, the getCenter() methos is used if available.
The Label option should reflect the actual value. This is preparation for the next commit.
Setting the option offset:[0, 0] and clickable:true causes the label <div> be just under the mouse, firing a 'mouseout' on the Path, making the Label disappear and re-appear again resulting in flickering or no label at all. This make 'clickable' and 'noHide' mutually exclusive. Also, in noHide:false mode, clicking the label is not possible anyway as it moves with the mouse.
The correct offsets depend on CSS. Make [0, 0] the default and use CSS 'margin-top' and 'margin-left' to handle it instead. This way, changing the offset option is not necessary when changing CSS like makeing the border smaller. Tested in FF, Chrome, Safari and even IE10.
If these options are set: { clickable: true, passClickToSource: true },
mouse click event will be passed to the source object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #123, but with the target branch changed to the new rebased leaflet-master.