[lua] Refactor Reactive Shield#10260
Merged
Merged
Conversation
Xaver-DaRed
reviewed
Jun 8, 2026
Refactors Reactive Shield
Xaver-DaRed
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Refactors code in Reactive Shield with a more accurate power formula. Did some brief testing at Lv. 50, 60, 70 & 99 and came up with...
damage = math.floor((skill / 16( + (INT / 6))
It's not perfect, and will sometimes deliver damage 1-2 damage too low, but it's a massive improvement over what was there before. There may be a dINT component as well, but I left a TODO to verify it further.
ReactiveShield.zip
Lv.70
INT 54
251 Skill
22-24 Damage
Lv.60
INT 45
203 Skill
17-19 Damage
Lv.50
INT 38
153 Skill
14-15 Damage
Lv.99
INT 81
Skill 424
42-45 Damage
Lv.99
INT 81+77
Skill 424
53-56 Damage
Steps to test these changes
Equip Reactive Shield, use Fire Maneuvers, get Blaze Spikes.