Skip to content

TextInput: refactor to useDisableableInput #3179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
labkey-nicka wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

TextInput: refactor to useDisableableInput #3179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/org/labkey/test/components/ui/entities/EntityBulkInsertDialog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,7 @@ public List<WebElement> fieldLabels()
WebElement quantity = Locator.tagWithId("input", "numItems")
.findWhenNeeded(getComponentElement());

WebElement description = Locator.tagWithId("textarea", "Description")
WebElement description = Locator.textarea("Description")
.findWhenNeeded(getComponentElement());

RadioButton derivativesOption = new RadioButton.RadioButtonFinder().withNameAndValue("creationType", "Derive")
Expand Down
9 changes: 7 additions & 2 deletions src/org/labkey/test/components/ui/entities/EntityBulkUpdateDialog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,10 +357,15 @@ public List<String> getFieldNames()
names.add(FieldKey.fromFieldKey(attribute).getFullName());
}

// Amount and Units is an example that has a "hide-label" for StoredAmount
// Amount and Units is an example that has a "hide-label" for StoredAmount. A hidden label renders no
// data-fieldkey span, so the field key comes from the name of the control the label points at.
List<WebElement> hiddenLabels = Locator.tagWithClass("label", "hide-label").withAttribute("for")
.findElements(elementCache());
names.addAll(hiddenLabels.stream().map(a -> FieldKey.fromFieldKey(a.getDomAttribute("for")).getFullName()).toList());
for (WebElement label : hiddenLabels)
{
WebElement control = Locator.id(label.getDomAttribute("for")).findElement(elementCache());
names.add(FieldKey.fromFieldKey(control.getDomAttribute("name")).getFullName());
}

return names;
}
Expand Down