Fix death notification firing, a duplicate Assign To field, and dropped birth/arrival times

[labkey-martyp]

Rationale

Three NIRC updates: the death notification now fires for a death recorded alongside its necropsy, the Submit For Review dialog no longer shows a duplicate Assign To field when reopened, and birth and arrival entry now keeps the time of day.

The notification and the accompanying procedure-order update were keyed off the 'Request: Pending' state. A death entered on the same form as its necropsy is submitted straight to 'Review Required' or 'Completed' and never passes through that state, so neither ran for it.

The Submit For Review dialog claimed a page-wide element name for its Assign To field and only hid itself when cancelled, so a second open rendered the previous dialog's field next to the new one. Cancelling to correct a value and reopening is routine in the combined death-and-necropsy flow, which is where it showed up.

Times were lost twice over: neither date column carried a format with a time component, so both forms presented a date-only editor, and the birth trigger separately discarded the time server-side, which carried through to the records derived from the birth date.

Related Pull Requests

None.

Changes

• The deaths trigger keys the notification off the move out of draft instead of off one specific target state, so it fires once per record no matter which submit button created it.
• The procedure-order update moves with the notification, so it also runs for a death recorded alongside its necropsy.
• The Submit For Review dialog no longer claims a page-wide element name and now discards itself when cancelled, so reopening it renders a single Assign To field.
• The birth and arrival date columns declare a date-and-time display format, so entry offers a time-of-day editor and the stored time is visible.
• The birth trigger no longer discards the time from the birth date, so it survives onto the birth record and everything derived from it.

[labkey-bpatel]

This was by design, since Submit Death was meant to notify the relevant users so they could complete the Necropsy. When Death and Necropsy are submitted together, the Necropsy is already entered, so the notification seems moot in that case. But I could be missing some additional context now.

[labkey-martyp]

That's what they've asked for now.

[NIRC-IT]

The submit death allows AR to notify VR of a pending necropsy but VR can do a straight necropsy and now AR is not notified. The AR managers are in the death notification list but a two step process is undesired for VR (submit death for email, then submit necropsy for review). The head vet still has to submit final regardless of either path.