TextInput: refactor to useDisableableInput - #2071
Open
labkey-nicka wants to merge 12 commits into
Open
Conversation
labkey-nicka
commented
Aug 30, 2026
| if (startFocused && !didFocus && queryColumn && queryColumn.name) { | ||
| this.textInput.current?.focus(); | ||
| this.setState({ didFocus: true }); | ||
| export const TextInput: FC<TextInputProps> = props => { |
Contributor
Author
There was a problem hiding this comment.
As you'll note, this work leaves CheckboxInput and DatePickerInput as the only remaining implementations of DisableableInput. I plan on refactoring those separately.
| this.setState({ didFocus: true }); | ||
| export const TextInput: FC<TextInputProps> = props => { | ||
| // Extract DisableableInputProps, TextInputProps | ||
| const { |
Contributor
Author
There was a problem hiding this comment.
I'm targeting v26.10 for these changes so merging will hold off until at least v26.9 is branched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This refactors
TextInputandTextAreaInputto functional components so that they can useuseDisableableInputfor disabled state management.Related Pull Requests
Changes
TextInput,TextAreaInputandTextChoiceInputto functional componentsdisableInputprop onTextInputin favor of pre-existingdisabledpropidrather than relying on the column'sfieldKeytype="number"inAmountUnitInputas it was always overridden totype="text"byTextInput.TextAreaInput.onChange()updated to takenameparameter (consistent with other inputs)TextChoiceInputis a higher-order-component of aSelectInputwhich implements disabled state itself. No need foruseDisableableInput.TextChoiceInput