QueryModelLoader: use selectRows - #2070
Merged
Merged
Conversation
labkey-alan
approved these changes
Aug 31, 2026
labkey-alan
left a comment
labkey-alan
left a comment
Contributor
There was a problem hiding this comment.
I left some minor nits
labkey-nicka
force-pushed
the
fb_query_model_select_rows
branch
from
September 1, 2026 18:38
9eb07a7 to
56f60f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This switches the
QueryModelLoaderto useselectRows()instead ofselectRowsDeprecated(). I've prioritized keeping the interface/contract with theQueryModelthe same (i.e., theorderedRows: string[]and therows: Record<string, Row>).Related Pull Requests
Changes
resolveRowKey()to have common processing for resolving the key from metadataISelectRowsResultto be more deeply expressedmetaDatathroughselectRowsGridMessagetoSelectRowsMessage