Skip to content

Use standard DDL instead of fn_dropifexists() proc #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-adam merged 1 commit into from
Sep 4, 2026
Merged

Use standard DDL instead of fn_dropifexists() proc #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions OConnor/resources/schemas/dbscripts/postgresql/oconnor-drop.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@
-- NOTE: Don't remove any of these drop statements, even if we stop re-creating the view in *-create.sql. Drop statements must
-- remain in place so we can correctly upgrade from older versions, which we commit to for two years after each release.

SELECT core.fn_dropifexists('max_virus_challenge_date', 'oconnor', 'VIEW', NULL);
SELECT core.fn_dropifexists('active_quotes', 'oconnor', 'VIEW', NULL);
SELECT core.fn_dropifexists('active_grants', 'oconnor', 'VIEW', NULL);
DROP VIEW IF EXISTS oconnor.max_virus_challenge_date;
DROP VIEW IF EXISTS oconnor.active_quotes;
DROP VIEW IF EXISTS oconnor.active_grants;
2 changes: 1 addition & 1 deletion OConnorExperiments/resources/schemas/dbscripts/postgresql/oconnorexperiments-0.00-14.30.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ CREATE TABLE OConnorExperiments.ParentExperiments
/* oconnorexperiments-13.10-13.20.sql */

-- drop ParentExperiments.Container FK to allow bulk folder delete
SELECT core.fn_dropifexists('ParentExperiments', 'OConnorExperiments', 'constraint', 'FK_ParentExperiments_Container');
ALTER TABLE OConnorExperiments.ParentExperiments DROP CONSTRAINT IF EXISTS FK_ParentExperiments_Container;

/* oconnorexperiments-13.20-13.30.sql */

Expand Down
Loading