feat: add extensions support to local-setup#993
Conversation
|
Warning Review limit reached
More reviews will be available in 27 minutes and 6 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThis PR adds opt-in extension support to the Kuadrant local Kind cluster setup, enabling custom controller binaries to be injected into the operator container via init containers and emptyDir volumes. Configuration is controlled by three new make variables, a ChangesExtensions Support for Local Kind Setup
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@make/kuadrant.mk`:
- Around line 102-113: The JSON Patch used in the kubectl patch command will
fail if /spec/template/spec/initContainers already exists because the add
operation targets "/spec/template/spec/initContainers" instead of appending;
update the kubectl patch invocation that modifies the
kuadrant-operator-controller-manager deployment so it either appends to the
initContainers array (use the "/spec/template/spec/initContainers/-" path) or
switch to a strategic merge patch to merge/init/create initContainers safely
(apply the change that references the same containers block where volumes and
containers/0/volumeMounts are handled, keeping the copy-extensions init
container using $(EXTENSIONS_IMAGE) and the extensions-binary-volume
volumeMount).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 2b2fba7b-e3e2-4f3d-a86c-0cc8b6681c96
📒 Files selected for processing (6)
.claude/rules/extensions-setup.md.gitignoreCLAUDE.mdmake/kuadrant.mkmake/local-setup.mkmake/vars.mk
Signed-off-by: Silvia Tarabova <starabov@redhat.com>
2051ef9 to
e97464b
Compare
Important
This PR modifies shared/core testsuite code that could potentially affect multiple test areas. 2 reviewers should review this PR to ensure adequate coverage.
Description
local-setupviaINSTALL_EXTENSIONS=truedeploy-extensionsMake target patches the operator deployment with an init container that injects extension binaries from a configurable container imageextensions-manifests.yaml)Changes
New Features
deploy-extensionstarget inmake/kuadrant.mkthat applies CRDs/RBAC from a manifests file and patcheskuadrant-operator-controller-managerwith an init container andemptyDirvolume at/extensionsmake/vars.mk:INSTALL_EXTENSIONS,EXTENSIONS_IMAGE,EXTENSIONS_MANIFESTSlocal-setuptarget inmake/local-setup.mk(runs betweendeploy-kuadrant-operatoranddeploy-kuadrant-cr)Documentation
.claude/rules/extensions-setup.mdwith usage guide, environment variables, and manifests formatCLAUDE.mdwith extensions usage exampleextensions-manifests.yamlto.gitignore(user-specific content)Verification steps
extensions-manifests.yamlfile in the repository root, or specify a custom path viaEXTENSIONS_MANIFESTS=/path/to/manifests.yamlCloses #992
Summary by CodeRabbit
New Features
INSTALL_EXTENSIONS=trueparameter. Extensions are disabled by default.Documentation