fix: restore catalog prerequisite to catalog-build target#787
Conversation
The catalog used in the catalog-build step was never generated. Signed-off-by: Jim Fitzpatrick <jfitzpat@redhat.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughIn Changescatalog-build dependency fix
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Restores the
catalogprerequisite on thecatalog-buildMakefile target, which was accidentally dropped in #773.Without this dependency,
make catalog-buildskips catalog generation (dockerfile, operator.yaml, and OPM validation) and attempts to build a container image from potentially missing or stale catalog artifacts. This broke both localmake catalog-buildinvocations and CI catalog image builds.Changes
catalogas a prerequisite to thecatalog-buildtarget inmake/catalog.mk, restoring the dependency chain:catalog-build->catalog->opm/$(CATALOG_DOCKERFILE)/$(CATALOG_FILE).Test plan
make catalog-buildfrom a clean checkout and confirm it generates catalog content before building the imagebuild-catalogjob passes on this branchSummary by CodeRabbit