Skip to content

fix: restore catalog prerequisite to catalog-build target#787

Open
Boomatang wants to merge 1 commit into
mainfrom
fix_catalog-build
Open

fix: restore catalog prerequisite to catalog-build target#787
Boomatang wants to merge 1 commit into
mainfrom
fix_catalog-build

Conversation

@Boomatang

@Boomatang Boomatang commented Jun 24, 2026

Copy link
Copy Markdown
Member

Summary

Restores the catalog prerequisite on the catalog-build Makefile target, which was accidentally dropped in #773.

Without this dependency, make catalog-build skips catalog generation (dockerfile, operator.yaml, and OPM validation) and attempts to build a container image from potentially missing or stale catalog artifacts. This broke both local make catalog-build invocations and CI catalog image builds.

Changes

  • Added catalog as a prerequisite to the catalog-build target in make/catalog.mk, restoring the dependency chain: catalog-build -> catalog -> opm / $(CATALOG_DOCKERFILE) / $(CATALOG_FILE).

Test plan

  • Run make catalog-build from a clean checkout and confirm it generates catalog content before building the image
  • Verify CI build-catalog job passes on this branch

Summary by CodeRabbit

  • Chores
    • Updated the catalog image build process so the catalog content is generated first, helping ensure builds use the latest generated assets.
    • Kept the existing image build and tagging behaviour unchanged.

The catalog used in the catalog-build step was never generated.

Signed-off-by: Jim Fitzpatrick <jfitzpat@redhat.com>
@Boomatang Boomatang requested a review from mikenairn June 24, 2026 11:21
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 68083e27-4522-4284-acc4-31190289bc08

📥 Commits

Reviewing files that changed from the base of the PR and between f0ef781 and cef480c.

📒 Files selected for processing (1)
  • make/catalog.mk

📝 Walkthrough

Walkthrough

In make/catalog.mk, the catalog-build target is updated to declare catalog as an explicit prerequisite. This ensures the operator catalog content is generated before the Docker image build step executes.

Changes

catalog-build dependency fix

Layer / File(s) Summary
Add catalog prerequisite to catalog-build target
make/catalog.mk
catalog-build target gains catalog as an explicit prerequisite, enforcing that catalog content is generated before the Docker image is built.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A rabbit hops through the build with glee,
"Catalogue first!" it squeaks with delight,
No Docker shall run before content's in sight,
Dependencies ordered, as tidy as tea,
The pipeline now hops in the right sequence, quite right! 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: restoring the catalog prerequisite on the catalog-build target.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix_catalog-build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant