Remove all the code from deprecated v1beta2 API version#630
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (14)
💤 Files with no reviewable changes (7)
✅ Files skipped from review due to trivial changes (3)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughRemoves the Changesv1beta2 API Removal
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
guicassolato
left a comment
There was a problem hiding this comment.
Sorry, @averevki. Although I really appreciate you having sent this PR and removing v1beta2 straight away being how I personally would like to proceed indeed, TIL that OLM might actually block us from doing that:
OLM will not allow a serving version of CRD to be removed right away. Instead, a deprecated version of CRD should have been disabled first by marking
Servedfield in CRD tofalsefirst. Then, the non-serving version can be removed on the subsequent CRD upgrade.
Let's put this PR on hold for a while and provide users with a smoother upgrade path instead by first flipping v1beta2 to served: false, then completely remove it from the CRD in a consecutive release.
Signed-off-by: averevki <sandyverevkin@gmail.com>
|
This is good to go now. The v1beta2 has been marked as
|
Summary
Remove all the code from deprecated
v1beta2API version of the AuthConfig CRD. Only the currentv1beta3remains now.Closes #628
Changes
api/v1beta2/package and remove scheme registration frommain.gov1beta2oneOf patches and conversion webhook patchtests/v1beta2/e2e fixtures and removev1beta2from CI test matrixUpgrade considerations
v1beta3has been the current and default API version for a long time. This PR only removes the deprecatedv1beta2code. Users already onv1beta3— and clusters where Kuadrant was installed afterv1beta3became the CRD storage version — should not experience any issues upgrading.Users still referencing
apiVersion: authorino.kuadrant.io/v1beta2in their AuthConfig manifests must migrate tov1beta3before upgrading.Clusters where
v1beta2was previously the storage version may need to patch the CRDstoredVersions:kubectl patch crd authconfigs.authorino.kuadrant.io --type=json -p='[{"op":"replace","path":"/status/storedVersions","value":["v1beta3"]}]'Summary by CodeRabbit
Release Notes
Refactor
Documentation