Skip to content

Geo/update the readme for the c phi test#14490

Merged
Sabine-van-Dijk merged 13 commits into
masterfrom
geo/update-the-readme-for-the-c-phi-test
Jun 11, 2026
Merged

Geo/update the readme for the c phi test#14490
Sabine-van-Dijk merged 13 commits into
masterfrom
geo/update-the-readme-for-the-c-phi-test

Conversation

@Sabine-van-Dijk

Copy link
Copy Markdown
Contributor

Updated the README.md file for the C-Phi test case to point to the website and K0-procedure documentation.

Also formatted and cleaned the material and project parameter files.

@Sabine-van-Dijk Sabine-van-Dijk requested a review from a team as a code owner June 8, 2026 15:54

@markelov208 markelov208 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sabine, thank you very much for cleaning this test and fixing the description. Follow your changes, I see that the original text is not really English. Could you also improve the text a bit? Thank you.

Comment thread applications/GeoMechanicsApplication/tests/C-Phi_reduction_process/README.md Outdated
Comment thread applications/GeoMechanicsApplication/tests/C-Phi_reduction_process/README.md Outdated

@WPK4FEM WPK4FEM left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sabine,

Glad to see that this also reduces the number of json files that is excluded from formatting. I have some small nagging about textual things, but am generally happy with the changes.

Regards, Wijtze Pieter

Comment thread applications/GeoMechanicsApplication/tests/C-Phi_reduction_process/README.md Outdated
Comment thread applications/GeoMechanicsApplication/tests/C-Phi_reduction_process/README.md Outdated
Comment thread applications/GeoMechanicsApplication/tests/C-Phi_reduction_process/README.md Outdated
Comment thread applications/GeoMechanicsApplication/tests/C-Phi_reduction_process/README.md Outdated

@markelov208 markelov208 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sabine, thank you very much for processing the comments. I have two minor comments on the text.

Comment thread applications/GeoMechanicsApplication/tests/C-Phi_reduction_process/README.md Outdated
Comment thread applications/GeoMechanicsApplication/tests/C-Phi_reduction_process/README.md Outdated

@markelov208 markelov208 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sabine, I think the PR can be merged. Let's wait for Wijtze Pieter's decision.

@WPK4FEM WPK4FEM left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sabine,

Although I think that we generally speak about gravity i.s.o. gravitation, the description is correct.

Good to go for me.

Regards, Wijtze Pieter

@Sabine-van-Dijk Sabine-van-Dijk merged commit 4e9a82f into master Jun 11, 2026
10 checks passed
@Sabine-van-Dijk Sabine-van-Dijk deleted the geo/update-the-readme-for-the-c-phi-test branch June 11, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[GeoMechanicsApplication] Update the README.md for the C-Phi test

3 participants