[Core] Improve CartesianMeshGeneratorModeler#14481
Open
loumalouomega wants to merge 52 commits into
Open
Conversation
… functionality - Updated class documentation to provide detailed descriptions of methods and parameters. - Replaced traditional include guards with #pragma once for better compatibility. - Simplified type definitions using 'using' instead of 'typedef'. - Enhanced constructor definitions and added default constructor for better usability. - Refactored GenerateMesh method and related calculations for clarity and maintainability. - Improved naming conventions and code organization for better readability. - Removed unused code and comments to streamline the implementation.
loumalouomega
added
Cleanup
Kratos Core
Python
Testing
Legacy
…ables and buffer size during mesh generation
This reverts commit b243fd2.
…jection algorithm
…nerateCartesianMesh in modeler and Python bindings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: ✨ Feature
about: Improve
CartesianMeshGeneratorModeler📝 Description
This PR improves the
CartesianMeshGeneratorModelerclass with significant refactoring for code clarity, maintainability, and adds comprehensive test coverage (both C++ and Python).Validation
test_cartesian_mesh_generator_modeler.cpp) with 192 lines of test codetest_cartesian_mesh_generator_modeler.py) with 188 lines of test codetest_KratosCore.py)🆕 Changelog
Core Refactoring
#pragma oncefor better compatibilityusinginstead oftypedefGenerateMeshmethod and related calculations for improved clarity and maintainabilityIntegration & Bindings
CartesianMeshGeneratorModelerPython bindings to enable usage from Python scriptsCartesianMeshGeneratorModelerintoKratosApplicationcore moduleFiles Modified
kratos/tests/test_cartesian_mesh_generator_modeler.cpp(new test)Commits