Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/test_and_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,8 @@ jobs:
run: |
mkdir -p trame_vuetify/module/vue3-serve/{fonts,css}
cd trame_vuetify/module/vue3-serve

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be vuetify4-serve or something. Someone should still be able to choose between vuetify2, vuetify3, vuetify4 and at some point vuetify0...

curl https://cdn.jsdelivr.net/npm/vuetify@3.11.2/dist/vuetify.min.css -Lo vuetify3.css
curl https://cdn.jsdelivr.net/npm/vuetify@3.11.2/dist/vuetify.min.js -Lo vuetify3.js
curl https://cdn.jsdelivr.net/npm/vuetify@4.0.5/dist/vuetify.min.css -Lo vuetify3.css

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should copy it to vuetify4 not 3.

curl https://cdn.jsdelivr.net/npm/vuetify@4.0.5/dist/vuetify.min.js -Lo vuetify3.js
curl https://cdn.jsdelivr.net/npm/@mdi/font@7.x/css/materialdesignicons.min.css -Lo css/mdi.css
curl https://cdn.jsdelivr.net/npm/@mdi/font@7.x/fonts/materialdesignicons-webfont.woff2 -Lo fonts/materialdesignicons-webfont.woff2

Expand Down Expand Up @@ -137,8 +137,8 @@ jobs:
run: |
mkdir -p trame_vuetify/module/vue3-serve/{fonts,css}
cd trame_vuetify/module/vue3-serve
curl https://cdn.jsdelivr.net/npm/vuetify@3.11.2/dist/vuetify.min.css -Lo vuetify3.css
curl https://cdn.jsdelivr.net/npm/vuetify@3.11.2/dist/vuetify.min.js -Lo vuetify3.js
curl https://cdn.jsdelivr.net/npm/vuetify@4.0.5/dist/vuetify.min.css -Lo vuetify3.css
curl https://cdn.jsdelivr.net/npm/vuetify@4.0.5/dist/vuetify.min.js -Lo vuetify3.js
curl https://cdn.jsdelivr.net/npm/@mdi/font@7.x/css/materialdesignicons.min.css -Lo css/mdi.css
curl https://cdn.jsdelivr.net/npm/@mdi/font@7.x/fonts/materialdesignicons-webfont.woff2 -Lo fonts/materialdesignicons-webfont.woff2

Expand Down
2 changes: 1 addition & 1 deletion README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -109,5 +109,5 @@ Share your experience `with a testimonial <https://github.com/Kitware/trame/issu
JavaScript dependency
-----------------------------------------------------------

This Python package bundle the following Vuetify libraries. For ``client_type="vue2"``, it exposes ``vuetify@2.7.1`` and for ``client_type="vue3"``, it exposes ``vuetify@3.11.2``.
This Python package bundle the following Vuetify libraries. For ``client_type="vue2"``, it exposes ``vuetify@2.7.1`` and for ``client_type="vue3"``, it exposes ``vuetify@4.0.5``.
If you would like us to upgrade any of those dependencies, `please reach out <https://www.kitware.com/trame/>`_.
Loading
Loading