chore(gastown): remove manual request logging middleware#3152
Closed
chore(gastown): remove manual request logging middleware#3152
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge This is a straightforward, safe deletion. The removed middleware was indeed redundant:
Latest commit added only a blank line — no functional change. Files Reviewed (1 file)
Reviewed by claude-4.6-sonnet-20260217 · 146,035 tokens |
162dd96 to
62a655f
Compare
62a655f to
27be16a
Compare
Contributor
Author
|
Superseded by #3158. Closing as duplicate from convoy retry loop. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the redundant request-logging middleware from
gastown.worker.ts. This middleware logged every HTTP request twice (incoming-->and outgoing<--) vialogger.info(), duplicating the structured AE events already emitted by the per-routeinstrumented()wrapper inanalytics.middleware.ts.Removed:
import { logger } from './util/log.util'(now unused at the worker level)RE_ORG,RE_TOWN,RE_RIG,RE_AGENT), thelogger.setTags()call, and bothlogger.info()linesPreserved:
timingMiddleware— still capturesrequestStartTimeforinstrumented()to computedurationMsuseWorkersLogger('gastown-worker')— still establishes AsyncLocalStorage context for log enrichmentsetTagscalls fororgIdanduserId— still tag downstreamlogger.*callsVerification
Diff: 30 lines deleted, 0 added, only
services/gastown/src/gastown.worker.tsmodified.Visual Changes
N/A
Reviewer Notes
The removed
logger.setTagswas only consumed by the twologger.infolines being removed. Auth middleware continues to setorgId/userIdtags from JWT claims. Town.do.ts runs in a separate isolate and has its ownsetTagscalls.