Skip to content

using EltypeExtensions: elconvert#105

Open
putianyi889 wants to merge 5 commits intoJuliaApproximation:masterfrom
putianyi889:patch-2
Open

using EltypeExtensions: elconvert#105
putianyi889 wants to merge 5 commits intoJuliaApproximation:masterfrom
putianyi889:patch-2

Conversation

@putianyi889
Copy link
Copy Markdown
Contributor

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 1, 2024

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 64.21%. Comparing base (b0741da) to head (9ec8020).
⚠️ Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
src/quasibroadcast.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
- Coverage   64.25%   64.21%   -0.04%     
==========================================
  Files          23       23              
  Lines        1835     1836       +1     
==========================================
  Hits         1179     1179              
- Misses        656      657       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@putianyi889 putianyi889 mentioned this pull request Nov 1, 2024
4 tasks
@putianyi889
Copy link
Copy Markdown
Contributor Author

the drop in coverage is expected due to #113

@dlfivefifty
Copy link
Copy Markdown
Member

This could just be an extension in EltypeExtensions.jl

@putianyi889
Copy link
Copy Markdown
Contributor Author

This could just be an extension in EltypeExtensions.jl

It wouldn't work since EltypeExtensions is low-level. Making it a dependent will cause dependency loop error.

@dlfivefifty
Copy link
Copy Markdown
Member

That's not true. If it's an extension it's only loaded when the downstream package is loaded so there is no circular dependency.

@dlfivefifty
Copy link
Copy Markdown
Member

But I accept your point that it would be weird

@putianyi889
Copy link
Copy Markdown
Contributor Author

putianyi889 commented Dec 20, 2024

That's not true. If it's an extension it's only loaded when the downstream package is loaded so there is no circular dependency.

When I tried adding extensions I did get errors. I think it's because Project.toml needs to have compatible versions, and the version-dependencies form loops which Julia can't resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants