Skip to content

[codex] Preserve explicit model capabilities in settings #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LeonLiuMercaso wants to merge 1 commit into from
Closed

[codex] Preserve explicit model capabilities in settings #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion desktop/src/pages/Settings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ import {
normalizeImageModelFetchBaseURL,
normalizeAiModelDescriptors,
normalizeSourceModels,
isLikelyTranscriptionModel,
parseAiSources,
parseEnvText,
parseMcpServers,
Expand Down Expand Up @@ -1108,6 +1109,13 @@ export function Settings({
? (sourceModelCapabilityDrafts[addModelModalSource.id] || 'chat')
: 'chat';

const resolveCandidateModelCapability = useCallback((model: AiModelDescriptor): ModelCapability => {
if (model.capabilities.includes('transcription') || isLikelyTranscriptionModel(model.id)) {
return 'transcription';
}
return model.capabilities.find((capability) => capability !== 'chat') || model.capabilities[0] || 'chat';
}, []);

const groupedAiPresets = useMemo<AiPresetGroup[]>(() => {
const codingPlan = AI_SOURCE_PRESETS.filter((preset) => preset.group === 'coding-plan');
const general = AI_SOURCE_PRESETS.filter((preset) => preset.group !== 'coding-plan');
Expand Down Expand Up @@ -5860,7 +5868,7 @@ export function Settings({
setSourceModelDrafts((prev) => ({ ...prev, [addModelModalSource.id]: item.id }));
setSourceModelCapabilityDrafts((prev) => ({
...prev,
[addModelModalSource.id]: item.capabilities[0] || 'chat',
[addModelModalSource.id]: resolveCandidateModelCapability(item),
}));
}}
className="px-2 py-1 text-[11px] rounded border border-border hover:bg-surface-secondary transition-colors flex items-center gap-1.5"
Expand Down
7 changes: 5 additions & 2 deletions desktop/src/pages/settings/shared.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1460,12 +1460,15 @@ export const toAiModelDescriptor = (
...(Array.isArray(model?.capabilities) ? model.capabilities : []),
model?.capability,
];
const capabilities = explicitCapabilities.some((value) => String(value || '').trim())
const hasExplicitCapabilities = explicitCapabilities.some((value) => String(value || '').trim());
const capabilities = hasExplicitCapabilities
? normalizeModelCapabilities(explicitCapabilities)
: inferModelCapabilities(id);
return {
id,
capabilities: forcedCapabilities.length > 0 ? forcedCapabilities : capabilities,
capabilities: hasExplicitCapabilities
? capabilities
: (forcedCapabilities.length > 0 ? forcedCapabilities : capabilities),
inputCapabilities: getModelInputCapabilities(id),
};
};
Expand Down