Skip to content

chore: migrate agent skills to shared store - #146

Merged
Jacksondr5 merged 2 commits into
mainfrom
chore/shared-agent-skills
Aug 9, 2026
Merged

Jacksondr5 merged 2 commits into
mainfrom
chore/shared-agent-skills

Conversation

@Jacksondr5

@Jacksondr5 Jacksondr5 commented Aug 8, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • remove the six stale, repo-local Convex skill copies and their skill lock
  • keep current Convex-generated guidance while setting aiFiles.skills.agents to an empty list so local skills are not recreated
  • document the shared home-level skill model and origin-aware Playwright/Clerk workflow
  • exclude vendor-managed skill files and generated Convex AI guidance from CodeRabbit review

Verification

  • pnpm typecheck
  • pnpm exec prettier --check .coderabbit.yaml AGENTS.md convex.json convex/_generated/ai/ai-files.state.json
  • git diff --check origin/main...HEAD
  • npx convex ai-files status (guidelines and managed AGENTS/CLAUDE sections current; project-local skill warning is expected)
  • independent Traycer review completed; findings addressed
  • post-rebase stable patch IDs match

Notes

The selected Convex skills are installed at user scope via the shared npx skills store. This PR intentionally contains only the repository-side migration and guardrails.

Summary by CodeRabbit

  • Documentation
    • Updated Playwright guidance with interactive workflows, authentication handling, explicit base URL setup, and CLI usage.
    • Expanded Convex development guidance with shared skill installation and database API compatibility notes.
  • Configuration
    • Added Convex project configuration for schema and AI skill settings.
    • Refined review filters to exclude additional vendor-managed, lock, and generated files.

@vercel

vercel Bot commented Aug 8, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
trade-tracker Ready Ready Preview Aug 9, 2026 5:32pm

Request Review

@coderabbitai

coderabbitai Bot commented Aug 8, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6784dfdd-4e69-44a9-9059-a535a4bcae4d

📥 Commits

Reviewing files that changed from the base of the PR and between 6c9ec38 and b4815c9.

📒 Files selected for processing (1)
  • AGENTS.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • AGENTS.md

📝 Walkthrough

Walkthrough

The pull request expands review path exclusions, updates Playwright workflow guidance, and adds Convex AI configuration and operating guidance.

Changes

Agent guidance and configuration

Layer / File(s) Summary
Review path exclusions
.coderabbit.yaml
Review filters now exclude Claude skills, skills directories, lock data, and generated Convex AI code.
Playwright workflow guidance
AGENTS.md
Playwright instructions now cover interactive and CLI workflows, saved-auth origins, base URL configuration, and the shared CLI wrapper.
Convex agent configuration
AGENTS.md, convex.json
Convex guidance now covers generated guidelines, shared skills, status warnings, and database call compatibility. convex.json initializes the AI skills agent list.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • Jacksondr5/trade-tracker#99: The main PR directly builds on Convex skill packaging by updating AGENTS.md, convex.json, and related skills metadata handling.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the primary change: migrating agent skills to a shared store.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/shared-agent-skills

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@AGENTS.md`:
- Line 61: Update the development-server instructions in AGENTS.md to replace
`pnpm convex dev` with `npx convex dev`, and explicitly state that `pnpm dev`
and `npx convex dev` must run in separate terminals.
- Around line 161-163: Add the global Convex agent-skill bootstrap commands,
`npx skills add get-convex/agent-skills --all --global` and `npx skills ls -g`,
to the Shared Agent Skills section in AGENTS.md. Clarify that the empty
`aiFiles.skills.agents` configuration does not install these user-scoped skills
through `npx convex ai-files install`.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: eafd66c8-c914-447d-bdb5-330ad71d306e

📥 Commits

Reviewing files that changed from the base of the PR and between 90d0b78 and 6c9ec38.

⛔ Files ignored due to path filters (45)
  • .agents/skills/convex-create-component/SKILL.md is excluded by !.agents/**
  • .agents/skills/convex-create-component/agents/openai.yaml is excluded by !.agents/**
  • .agents/skills/convex-create-component/assets/icon.svg is excluded by !**/*.svg, !.agents/**
  • .agents/skills/convex-create-component/references/advanced-patterns.md is excluded by !.agents/**
  • .agents/skills/convex-create-component/references/hybrid-components.md is excluded by !.agents/**
  • .agents/skills/convex-create-component/references/local-components.md is excluded by !.agents/**
  • .agents/skills/convex-create-component/references/packaged-components.md is excluded by !.agents/**
  • .agents/skills/convex-migration-helper/SKILL.md is excluded by !.agents/**
  • .agents/skills/convex-migration-helper/agents/openai.yaml is excluded by !.agents/**
  • .agents/skills/convex-migration-helper/assets/icon.svg is excluded by !**/*.svg, !.agents/**
  • .agents/skills/convex-migration-helper/references/migration-patterns.md is excluded by !.agents/**
  • .agents/skills/convex-migration-helper/references/migrations-component.md is excluded by !.agents/**
  • .agents/skills/convex-performance-audit/SKILL.md is excluded by !.agents/**
  • .agents/skills/convex-performance-audit/agents/openai.yaml is excluded by !.agents/**
  • .agents/skills/convex-performance-audit/assets/icon.svg is excluded by !**/*.svg, !.agents/**
  • .agents/skills/convex-performance-audit/references/function-budget.md is excluded by !.agents/**
  • .agents/skills/convex-performance-audit/references/hot-path-rules.md is excluded by !.agents/**
  • .agents/skills/convex-performance-audit/references/occ-conflicts.md is excluded by !.agents/**
  • .agents/skills/convex-performance-audit/references/subscription-cost.md is excluded by !.agents/**
  • .agents/skills/convex-quickstart/SKILL.md is excluded by !.agents/**
  • .agents/skills/convex-quickstart/agents/openai.yaml is excluded by !.agents/**
  • .agents/skills/convex-quickstart/assets/icon.svg is excluded by !**/*.svg, !.agents/**
  • .agents/skills/convex-setup-auth/SKILL.md is excluded by !.agents/**
  • .agents/skills/convex-setup-auth/agents/openai.yaml is excluded by !.agents/**
  • .agents/skills/convex-setup-auth/assets/icon.svg is excluded by !**/*.svg, !.agents/**
  • .agents/skills/convex-setup-auth/references/auth0.md is excluded by !.agents/**
  • .agents/skills/convex-setup-auth/references/clerk.md is excluded by !.agents/**
  • .agents/skills/convex-setup-auth/references/convex-auth.md is excluded by !.agents/**
  • .agents/skills/convex-setup-auth/references/workos-authkit.md is excluded by !.agents/**
  • .agents/skills/convex/SKILL.md is excluded by !.agents/**
  • .claude/skills/convex is excluded by !.claude/skills/**
  • .claude/skills/convex-create-component is excluded by !.claude/skills/**
  • .claude/skills/convex-migration-helper is excluded by !.claude/skills/**
  • .claude/skills/convex-performance-audit is excluded by !.claude/skills/**
  • .claude/skills/convex-quickstart is excluded by !.claude/skills/**
  • .claude/skills/convex-setup-auth is excluded by !.claude/skills/**
  • convex/_generated/ai/ai-files.state.json is excluded by !**/_generated/**, !convex/_generated/ai/**
  • convex/_generated/ai/guidelines.md is excluded by !**/_generated/**, !convex/_generated/ai/**
  • skills-lock.json is excluded by !skills-lock.json
  • skills/convex is excluded by !skills/**
  • skills/convex-create-component is excluded by !skills/**
  • skills/convex-migration-helper is excluded by !skills/**
  • skills/convex-performance-audit is excluded by !skills/**
  • skills/convex-quickstart is excluded by !skills/**
  • skills/convex-setup-auth is excluded by !skills/**
📒 Files selected for processing (3)
  • .coderabbit.yaml
  • AGENTS.md
  • convex.json

Comment thread AGENTS.md Outdated
Comment thread AGENTS.md
@Jacksondr5
Jacksondr5 merged commit 7e99ed9 into main Aug 9, 2026
5 checks passed
@Jacksondr5
Jacksondr5 deleted the chore/shared-agent-skills branch August 9, 2026 17:58

This branch was successfully deployed

1 active deployment
Preview — b4815c9a Deployed Aug 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant