Skip to content

Fix BLS pop dst and no context API - #695

Open
perturbing wants to merge 5 commits into
masterfrom
perturbing/fix-bls-pop-dst
Open

Fix BLS pop dst and no context API#695
perturbing wants to merge 5 commits into
masterfrom
perturbing/fix-bls-pop-dst

Conversation

@perturbing

@perturbing perturbing commented Aug 18, 2026

Copy link
Copy Markdown
Member

Description

In the IETF draft of BLS signatures, the domain separation tag of the proof of possession should be separated from normal signatures. E.g., this means we should use the prefix tag BLS_POP_ for the PoP and BLS_SIG_ for signatures (which we already did).

Before, we used the BLS_SIG_ prefix for PoP as well; this is insecure as you can trick a key holder into signing a PoP without that intent via the signature path(can be useful in a rogue key attack).

This PR also fixes a typo in the Curve family description.

Credits to @colll78

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
    New section is never added with the code changes. (See RELEASING.md)
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated.
    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Self-reviewed the diff

@perturbing
perturbing requested a review from lehins as a code owner August 18, 2026 08:49
@perturbing
perturbing force-pushed the perturbing/fix-bls-pop-dst branch from 67e7161 to 30a51d9 Compare August 18, 2026 09:16

@ch1bo ch1bo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make the API simpler for the normal signature case too?

Comment thread cardano-crypto-class/src/Cardano/Crypto/DSIGN/BLS12381/Internal.hs Outdated
@colll78

colll78 commented Aug 18, 2026

Copy link
Copy Markdown

Identified and reported by Anastasia Labs.

🫡

@ch1bo ch1bo changed the title fix bls pop dst and typo Fix BLS pop dst and no context API Aug 25, 2026
@ch1bo ch1bo moved this from Todo to In Progress in Leios roadmap & activity Aug 25, 2026
@perturbing
perturbing requested a review from ch1bo August 25, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants