Repository navigation
chore: update Go to 1.26.10, Node to 26.12.1 and the CA bundle #458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
6f68a2f
deps: update Go to 1.26.10, Node to 26.12.1 and the CA bundle
Vligai 88e9f79
docs: require Go 1.26.10 and name the current build images
Vligai eace830
deps: re-pin the isolation image to the current node 26.12.1 digest
Vligai 2a903a1
docs: build the example agent container on Node 22
Vligai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| module github.com/Infisical/agent-vault | ||
|
|
||
| go 1.25.0 | ||
| go 1.26.10 | ||
|
|
||
| require ( | ||
| github.com/charmbracelet/huh v1.0.0 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 After merge, the Daytona example fails at its Go build step, because it compiles main with golang:1.25-alpine. That image cannot satisfy the new
go 1.26.10directive. Official golang images set GOTOOLCHAIN=local, so a 1.25 toolchain refuses a module that requires go >= 1.26.10 instead of downloading a newer one. Fix: update every pinned or documented Go 1.25 reference along with the directive. Use golang:1.27-alpine (or 1.26) in the example, and say Go 1.26.10+ in the docs. Same pattern at 4 sites (examples/daytona-openai-realtime/run.mjs:27, docs/self-hosting/local.mdx:28, docs/installation.mdx:41, docs/self-hosting/docker.mdx:17). [also at: examples/daytona-openai-realtime/run.mjs:28 - After merge, the Daytona example can no longer build agent-vault from main. Its build container runs Go 1.25, but go.mod now requires 1.26.10. go.mod:3 moves thegodirective from 1.25.0 to 1.26.10. run.mjs:27 still builds insidegolang:1.25-alpine, and the official golang images setGOTOOLCHAIN=local, sogo buildexits with "go.mod requires go >= 1.26.10".]Why this was flagged
examples/daytona-openai-realtime/run.mjs:244 sets AGENT_VAULT_REF to "main" by default, and line 23 clones that ref. Line 27 then runs
go buildinsidegolang:1.25-alpine. After this merge, go.mod:3 on main readsgo 1.26.10. The official golang images shipENV GOTOOLCHAIN=local, so Go 1.25 exits with "go.mod requires go >= 1.26.10 (running go 1.25.x; GOTOOLCHAIN=local)". The script runs underset -eu, so it aborts before the agent-vault container ever starts. On the base branch the directive isgo 1.25.0, which golang:1.25-alpine builds fine. CI cannot catch this: ci.yml reads the Go version from go.mod via go-version-file and never runs the example. The docs (local.mdx:28, installation.mdx:41) still list Go 1.25+ as the prerequisite. docker.mdx:17 still describes the builder as golang:1.25-alpine.Verification: go.mod:3 changes from
go 1.25.0togo 1.26.10. examples/daytona-openai-realtime/run.mjs:244 sets the defaultAGENT_VAULT_REF: process.env.AGENT_VAULT_REF ?? "main". The official golang images have setENV GOTOOLCHAIN=localsince Go 1.21. On the base branch,go 1.25.0builds fine with golang:1.25-alpine, so this is a regression this change introduces.