Adjust display init sequence to fix a rotation issue on the new ST7789P3 display controller#2440
Adjust display init sequence to fix a rotation issue on the new ST7789P3 display controller#2440JF002 wants to merge 1 commit into
Conversation
…9P3 display controller.
|
Build size and comparison to main:
|
|
In #2439 you mentioned a 120ms delay. I don’t see that in this change. Is it required? |
mark9064
left a comment
mark9064
left a comment
There was a problem hiding this comment.
Approval conditional on datasheet allowing us to set this while sleeping :)
Yes, you're right. The 120ms delay is suggested by PineStore. However, according to the datasheet, 5ms should be enough except if we want to send a SLEEPIN command again. In this case, we have to wait 120ms. This is already handled by St7789::EnsureSleepOutPostDelay().
According to my reading of the datasheet, all the commands that are now sent before SLEEPOUT are available in sleep mode, so we should be OK. |
3 participants
Those changes were suggested by PineStore engineering team to ensure that the new ST7789P3 will be supported by InfiniTime.
They basically move the call to the SLEEPOUT command after all the registers have been set. This should fix the rotation issue they detected while testing the new display.
Fixes #2439