Add support for nullable request/response#134
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to add support for nullable request/response types in the caching layer (and related handler usage), including a functional test case and a dependency update to a newer Immediate.Handlers version.
Changes:
- Relaxed
ApplicationCache<TRequest, TResponse>generic constraints to allow nullable reference types (class?). - Added a functional-test handler/cache pair that uses nullable request/response types.
- Updated
Immediate.Handlerspackage version from3.8.1to3.11.1.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/Immediate.Cache.FunctionalTests/NullableTypesCache.cs | Adds a functional test handler/cache using nullable request/response types. |
| src/Immediate.Cache.Shared/ApplicationCache.cs | Updates generic constraints to allow nullable reference type arguments. |
| Directory.Packages.props | Bumps Immediate.Handlers dependency version. |
Coverage Report for CI Build 29757980199Coverage decreased (-0.2%) to 94.017%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Member
Author
|
@coderabbitai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.