Battery Board - #310
Open
chethankarandikar wants to merge 52 commits into
Open
Battery Board#310chethankarandikar wants to merge 52 commits into
chethankarandikar wants to merge 52 commits into
Conversation
Added symbol for Display board, edited pull-up resistors and microcontroller expander to match the pins on the display board symbol.
…rs and Regulators
chethankarandikar
left a comment
chethankarandikar
left a comment
Contributor
Author
There was a problem hiding this comment.
good to merge i think
tjmcmanamen38
requested changes
Jul 21, 2026
tjmcmanamen38
left a comment
tjmcmanamen38
left a comment
Contributor
There was a problem hiding this comment.
Symbol library names should be changed to include manufacturer, e.g. along the lines of:
- Battery_Charging_Texas or Battery_Texas or Power_Texas or something
- Display_DisplayVision
- Regulator_Analog (yes technically its from Linear Technologies but they were absorbed by Analog Devices so I'd still call it Analog lol)
Contributor
Author
|
renamed symbol libs, moved HUSB238 out of battery charging to its own lib |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.