ruff format + github action to check formatting#52
Conversation
wlgrd
left a comment
There was a problem hiding this comment.
Agreeing that this should be put in to use :)
|
Thanks for the feedback, should be alright now |
|
Any chance of this getting merged any time soon? |
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: astral-sh/ruff-action@v3 | ||
|
No newline at end of file |
There was a problem hiding this comment.
I guess the formatter didn't run on the thing that formats 😆
If you clean it up then we can get it in (though it may require others to rebase and fixup).
I wouldn't mind putting in some more things, maybe even a .precommit step to make everything a bit easier.
|
This would be the next PR, I can be pretty opinionated on some of the boilerplate precommit/CI infrastructure so, before we take this further it would be good to get some feedback from original creators of this @NejcKle @hyperglitch @wlgrd If nobody has an opinion than either I or @Tjoms99 can bring it to the latest and greatest state. |
Issue #51
Having a standard linter to format the code will mitigate unrelated formatting changes that IDE's use (VSCode as an example) when contributing to this codebase. This will help with keeping the repo clean and tidy.
All that is needed is to run
In the root directory before pushing to the repo.
Also added a github action to check the ruff formatting on every push.