Repository navigation
ci: publish only freshly generated coverage reports - #1144
Closed
ChengShi-1 wants to merge 1 commit into
Closed
ChengShi-1 wants to merge 1 commit into
ChengShi-1 wants to merge 1 commit into
Conversation
|
coverage: 97.366% (-0.7%) from 98.063% — ci/fix-coveralls-baseline into develop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Failed component runs could upload the tracked
merged-coverage/lcov.infoeven when coverage generation and merging were skipped. Successful runs also merged that stale output back into the new report through the recursive input glob. This produced an invalid baseline for coverage comparisons.Delete and ignore the generated report, require both current input reports, merge only frontend and design-system coverage with repository-relative paths, and upload only after the preceding steps succeed.
Which issue(s) this PR closes:
Related to #1143. This isolates its coverage-reporting fix so develop can generate a fresh baseline before the Ubuntu compatibility PR is reassessed.
Special notes for your reviewer:
Develop's 98.063% baseline is from https://coveralls.io/builds/82542285. Its component job failed and skipped coverage checking and merging, but still uploaded the tracked report: https://github.com/IQSS/dataverse-frontend/actions/runs/39844215561/job/120053070802.
The corrected report on #1143 is 97.289% across 8,423 lines and 4,522 branches. Its component, e2e, lint, and accessibility jobs passed. Coveralls still compares against the old baseline; this PR cannot repair previously stored reports until develop publishes fresh coverage. The Ubuntu compatibility changes remain in #1143, so this isolated branch may still encounter those existing CI failures.
Suggestions on how to test this:
Focused merge validation passed: stale and unrelated reports excluded, design-system paths mapped correctly, repeated merges produce identical counts, and missing inputs fail. Typecheck, formatting, and lint passed locally (one existing ESLint warning). The same patch passed both component runs on #1143.
After merging, verify a successful develop component run uploads a fresh report, then rerun #1143.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes or changelog update needed for this change?:
No; CI reporting only.
Additional documentation:
None.