Repository navigation
Upgrade to CakePHP 5.3 and redesign lists, submission, news and footer - #363
Merged
Merged
Conversation
- Listings table: compound identity column with independent sorts, regrouped header, podium ranks, monospace metric readout - Submission view: result hero + masonry card grid, fixed markup bugs - Replace radar chart with interactive parallel-coordinates plot - Modernize buttons; switch to Inter + JetBrains Mono - Footer social icons to FontAwesome; refresh CTA banner - Remove breadcrumb site-wide; recolor bofs illustration - Clean up dead CSS and unused image assets
# Conflicts: # templates/Listings/list.php
sortWhitelist is deprecated in favour of sortableFields, and loadModel in favour of fetchTable. Both replacements work on 4.5, so clearing these ahead of the CakePHP 5 upgrade.
- Bump cakephp and its plugins to the 5.x lines (migrations 5, csvview 5, bake 3, debug_kit 5, codesniffer 5) and PHPUnit 11; drop the bugsnag plugin (no CakePHP 5 release) and pin php to >=8.2 <8.5 for math-executor. - Load the global function shims via composer autoload and import env() in the config files. - Use WebExceptionRenderer, rename the _cake_core_ cache to _cake_translations_, and drop the deprecated FileLog scopes flag. - Remove the RequestHandler component and the Bugsnag plugin load. - order() -> orderBy(); Table::get() array options -> named args. - Type the entity $_accessible/$_hidden properties as array.
- Rewrite phpunit.xml.dist to the PHPUnit 11 schema and the CakePHP fixture extension, dropping the removed FixtureInjector listener and whitelist filter. - ApplicationTest extends TestCase instead of the removed IntegrationTestCase. - Type the $fixtures properties as array (now typed on the parent). The suite loads and runs again; the remaining errors/failures are the pre-existing baked skeleton/stub tests, not migration regressions.
The fixtures truncate and reload their tables each run, so pointing the test connection at the dev/default database wipes that data. Note that the tables must already exist (fixtures reflect the schema, not create it).
- Add native parameter/return type hints across src and tests (phpcbf), after first correcting the @PARAM null docblocks that would otherwise have produced invalid bare null type declarations. - Drop three unused $release query assignments flagged as dead code. Leaves only advisory line-length warnings in pre-existing query code.
# Conflicts: # composer.lock
- Rework the submission Summary/Configuration/Reproducibility views around a shared header element (medal, rank pill, config strip, tabs), backed by a SubmissionsTable::rankingHeader() helper used by both controllers. - Give News and Rules a banner and standardize all page banners: recolored illustrations, image-left layout aligned with the nav, matched sizes. - Switch fonts to Inter/Lekton, use a neutral gray palette, and the new logo. - Match the customize table styling to the listing table. - Drop the stock-vector credits and the Twitter link on the contact page.
Brings in the SC26 BoF and call-for-submissions pages, the clarified production and submission rules, the trademark notice, and the updated lists page. Conflict resolution: - call.php: keep the redesigned banner markup with the SC'26 text. - logo.png: keep the new logo, which already carries the (R) mark, and drop the extra ® that upstream appended after it in the header.
The Font Awesome kit script was tied to a personal kit. Bootstrap Icons (MIT, loaded from jsDelivr) covers the five icons the site uses: github, envelope, slack, megaphone and trophy.
The suite drops, recreates and truncates tables, and the test connection in app_local.php points at a shared server. tests/bootstrap.php now builds the test connection from DATABASE_TEST_URL alone and refuses to run unless the host is local and the database is io500_test_local, before any table is touched. It then loads tests/schema.sql, a structure-only dump of the app's tables in which the listings_submissions view becomes a plain table (score stays FLOAT, like the per-list tables behind the view). bin/test-db.sh starts and removes a MySQL 8.0 container for this.
- Delete the 30 bake stubs (Listings, ListingsSubmissions, Releases and Types controller tests, and the *TableTest validation/buildRules stubs). Each only called markTestIncomplete; none tested anything. - PagesControllerTest: request real pages (/about) instead of the stock /pages/home, expect IO500 instead of CakePHP, and check the site's error page (debug off) for the 403 cases. - ApplicationTest: assert the app's actual plugins and middleware order. - Disable caching in tests: tmp/cache is owned by the web server. Before: 40 tests, 23 errors, 6 failures, 7 incomplete. After: 10 tests, all passing.
rankingHeader() counted the entries scoring higher than this one with 'score >' bound from PHP. List scores are FLOAT columns, and PHP turns the value into a 14-digit string when binding it (797.0380249023438 becomes 797.03802490234), so the entry counted itself: Shaheen III showed IO500#7 instead of IO500#6 on the ISC26 Production list. The comparison now uses a subquery on the stored value, so it never leaves SQL. Ties now rank by list entry id, and the list page orders tied scores the same way, so a row's position is stable and matches its submission page. The fixtures are rewritten with realistic typed data (real type ids, a FLOAT score, a tie, an unreleased release); the old ones were stock bake output that could not be inserted.
Entry ids in listings_submissions are only unique within a listing: the view unions one table per list, and each numbers its own rows. The rank subquery from the previous commit selected the entry by id alone, which matched one row per list and made the submission page fail with "Subquery returns more than 1 row" (e.g. /submissions/view/691). The test table now mirrors the view (primary key listing_id + id, so ids repeat across listings), and the fixture reuses entry id 1 in every listing, which reproduces the failure.
For the redesigned submission page: - listMemberships(): every released, ranked list a submission is on, newest first, with rank and entry count computed in SQL (same rule as rankingHeader: higher score, then lower entry id). - comparisonData(): one listing's entries in rank order with only the fields the page compares (identity for tooltips, bandwidth, metadata, 13 phase values). - positionHistory(): rank at each release for one list type, plus the entries within three places of it at the latest release. Checked on real data: Shaheen III (691) is on 12 ranked lists, 6th of 47 on ISC26 Production.
view() now also passes the ranked lists the submission is on and the
comparison data for one of them: ?list=<listing id> when it is one of
those lists, otherwise the latest release's Production list, otherwise
the latest release's best-ranked list.
New JSON action /submissions/compare/{id}/{listingId} returns the same
data for another of those lists, for switching lists on the page. It
returns 404 for any listing the submission is not on, and for unreleased
or unranked lists, and only sends whitelisted fields. Same response
pattern as /plots/data.json, cached for 10 minutes.
- List-type tabs and the Summary/Configuration/Reproducibility tabs use the same look: 15px semibold grey, red text and underline when active, 16px icons. Every tab has an outline icon (trophy for ranked lists, a list icon for Full; bar chart, sliders and a check badge on the submission pages). The call banner's megaphone is an outline too. - The home page marks the Production tab active. It compared against the URL's type segment, which the home URL does not have (and which also raised an undefined-index warning). - One row-hover shade, #f6f6f7.
The summary page now compares a submission with the ranked lists it is on, following the approved mockup: - Scores (IO500, bandwidth, metadata) in one box. - A system sheet, and next to it the ranking history: one row per release, one column per ranked list type, each cell the rank and entry count. It shows as many releases as the sheet has rows (older ones behind a toggle) and is hidden when the submission is on one list. - Results by phase, each with a strip plot of every entry on the selected list (log scale, min/max and median marked) and the rank on that list. - Position over time for the selected list type, with the entries ranked closest at the latest release; hidden when there is one release. - Bandwidth vs. metadata for the selected list. Clicking a ranking-history cell loads that list from the compare endpoint and redraws everything; ?list=<listing id> keeps the choice. The shared header (also on Configuration and Reproducibility) now shows the name, then institution, storage and reproducibility on one line; the rank pill and info strip are gone. Names from the database are escaped before going into tooltips. The old scatter queries and the CSS only the old page used are removed.
List table (home page and every list): - Plain rank numbers after the podium (1-3 keep their colored circle). - Measurements in the body font with aligned digits; score stays red and bold, bandwidth and metadata in dark text. Applies to every .tb table, so the BoF, records and customize tables stay consistent. - Unit row keeps its real case (GiB/s, kIOP/s), lighter INFORMATION / IO500 labels, bold SCORE header. - The system name also links to the submission, and clicking anywhere in a row opens it. - The header stays visible while scrolling (desktop); on phones the rank and identity columns stay in view while the table scrolls sideways. - Description in muted text. Fix: /list/<release>/full returned 500 when an entry had no institution. CakePHP 5's HtmlHelper::link() rejects a null title, which CakePHP 4 accepted. Both identity links now cast to string.
- Flat light background with a thin top border instead of the gradient. Text is darker grey (about 5:1 contrast, was about 2.3:1) and regular weight; only the Foundation name is bold. - The committee email is a link; the red but unlinked io500.org is gone. - Quick links (Lists, Rules, Submit, News, Contact). Submit points at the submission rules, which do not change between releases. - Icons carry their labels: Report an issue (GitHub), Mailing list (outline envelope), Join Slack. Grey, site red on hover. - Trademark notice on its own line at the bottom. - Columns stack on phones. The old footer and social-link CSS is removed.
Submit now opens https://www.submission.io500.org/ (in a new tab), where results are actually submitted, instead of the submission rules page.
positionHistory() accepts the memberships the caller already loaded, so the summary page and the compare endpoint run that query once instead of twice. Timing on real data (local site, remote database): the page's own queries take about 0.45 s; opening the database connection takes about 0.65 s; the page loads in about 1.5 s, like the unchanged list page. No result caching for now: it would save at most about 0.4 s and risk showing stale ranks.
…tabs Like the summary page, both tabs now redirect home when the submission is only on lists of a release that is not out yet. Configuration had no check at all, and Reproducibility only flashed a warning while still showing the answers. Both actions also stop computing the rank the old header used; the new header does not show it. Adds Questionnaires and ReproducibilityScores fixtures (one answer carries a script and an event handler, for the sanitizer tests to come).
The body is a flex column with the main area taking the spare height, so on pages with little content (e.g. a submission whose configuration is not available) the footer sits at the bottom of the window instead of under the content.
The questionnaire answers were shown inside read-only TinyMCE editors. They are now page text, as on the approved mockup: - A box with the submission's reproducibility level, its description and the four levels, the current one highlighted. - Jump-to links, then one section per question: the answer first, the exact question collapsed under "Question asked". Answers are HTML written by submitters, so AnswerFormatter cleans them with HTML Purifier (new dependency, ezyang/htmlpurifier): paragraphs, lists, links (nofollow, new tab, http/https/mailto only), tables and code stay; scripts, event handlers, images and javascript: links go. Text between ``` fences becomes a code block, plain URLs become links, and empty editor paragraphs are dropped. TinyMCE (webroot/js/tinymce, 124 files, 4.6 MB) was used only here and is removed.
The configuration is still drawn by the DCL widget from www.submission.io500.org (kept on purpose), but: - It no longer loads the submission site's own jQuery. That second copy replaced the site's jQuery and dropped its plugins, which raised "$(...).selectize is not a function" on this page. The widget works with the site's jQuery 3.5.0 (rendering and collapsing checked). - Its output is restyled to match the other tabs: quiet sections with nested parts indented, label/value rows instead of input boxes, dark headings instead of red uppercase ones. - Its collapse chevron used Font Awesome (removed); it is now drawn with Bootstrap Icons. The last unused sv-* rules (sv-panel, .mono, the --sv-* variables) are removed; only the shared header and tab styles remain. Locally the widget can only be seen with CORS disabled in the browser: the submission site only serves https://io500.org.
Revert the restyle of the DCL widget's output: the configuration shows in the widget's own style again, inside the bordered panel the tab used before. Kept: the widget no longer loads a second jQuery, and its collapse chevron is drawn with Bootstrap Icons (Font Awesome is gone).
rankingHeader() also counted the entry's rank and the list size with two queries over the listings_submissions view, but no page shows those any more: the Summary only needs the best released entry's score, and the Configuration and Reproducibility tabs only check that one exists. bestListing() returns just that entry. The float and tie regression tests move to listMemberships(), which computes the ranks the pages do show (checked: removing its tie-break makes the tie test fail).
The redesign removed breadcrumbs and their CSS site-wide, but four pages added upstream afterwards (SC'26 BoF, messaging policy, data handling, code of conduct) still had the markup, which showed as a raw bulleted "YOU ARE HERE" list linking to a submissions/latest page that no longer exists.
The error pages used their own layout, an old copy of the main one: it still loaded Roboto and not Bootstrap Icons, so the footer icons were blank, and the page had only an illustration. They now use the main layout (the copy is deleted) and show a heading, a short message and a "Back to the lists" link above the illustration.
Below 550px the banners scaled their illustration to fill the whole banner box, so it ran under the heading and text (News, Rules, Releases and other pages). The illustration is now capped at 340px high there, in the space above the text.
The tabs only read the hash on page load, so back/forward or a link to #talks on the page left the previous tab showing.
Measured against WCAG AA (4.5:1 for small text): - INFORMATION / IO500 group labels: #9aa0a8 (2.64:1) -> #6b7079 (4.98:1) - system name under the institution: #7b7d82 (4.12:1) -> #6b7079 - numbers on the gold/silver/bronze medals: white (1.93-3.32:1) -> dark (9.21, 6.95 and 5.35:1)
composer audit reported: - cakephp/cakephp 5.3.6: two critical SQL injection advisories in FunctionsBuilder and a high-severity SmtpTransport CRLF injection (fixed in 5.3.7) - composer/composer 2.10.2 (dev, via DebugKit): two advisories (2.10.3) - squizlabs/php_codesniffer 4.0.1 (dev): one high advisory (4.0.4) CakePHP stays on the 5.3 line (5.3.7) rather than the 5.4.3 that ^5.3 allows, to keep this a security-only change; composer.json is unchanged. composer audit is clean; tests (which fail on deprecations), coding standard and the main pages pass.
Ranks from 4th on show in red circles again, as before the list restyle (white on #d63b1e is 4.66:1, within WCAG AA); 1-3 keep the gold, silver and bronze medals with dark numbers. Circles now widen into a pill for 3-digit ranks, which were clipped (e.g. 201 on the Full list); this also applies to the customize page's ranks.
The gold, silver and bronze circles go back to white numbers, like the red ones (lower contrast on gold and silver, by request).
PHP_CodeSniffer 4 makes composer cs-check exit non-zero on warnings, so the 12 line-length warnings failed the CI lint job. Long messages, conditions and calls are wrapped; no behaviour change (the customize formula and record code read each column once into $value).
jeanbez
force-pushed
the
cakephp5-upgrade-plan
branch
from
October 7, 2026 17:47
7353ecc to
cbeccba
Compare
jeanbez
marked this pull request as ready for review
October 9, 2026 15:40
adilger
approved these changes
Oct 10, 2026
gflofst
self-requested a review
October 11, 2026 21:00
gflofst
approved these changes
Oct 11, 2026
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the site from CakePHP 4.5 to 5.3 and redesigns the main public pages.
Upgrade
?sort=parameter (pre-existing); sorting is now limited to the table's columns.Pages
/submissions/compare/{id}/{listingId}) loads other lists.Fixes
link()rejects null).Tests
Tests run only against a throwaway local MySQL (
bin/test-db.sh);tests/bootstrap.phprefuses any other database. 46 tests, all passing, and the run fails on any deprecation. See README → Running the tests.Before merging / deploying
main.yamldeploys withoutcomposer install: pause it or addcomposer install --no-dev; clear the CakePHP cache after deploy.