Logging information and set default parameters - #13
Merged
Merged
Conversation
christofid
requested changes
Sep 25, 2026
christofid
left a comment
christofid
left a comment
Member
There was a problem hiding this comment.
Nice work! I made a small comment about an argument renaming. Also 2 more general suggestions:
- I would exclude execute.sh and plot_cas_pes.py as they are just scripts that helps to run experiments.
- Diagnostics are nice to have but I would have a flag to enable/disable them rather than collect them every time
| # Processes used to build the circuit ensemble. 0 means one per CPU. | ||
| workers: int = 1 | ||
| # SQD solver parameters | ||
| method: Literal["exact", "qdrift"] = "qdrift" |
Member
There was a problem hiding this comment.
I would call it sqd_method as method it too generic and can be vague
ter04
force-pushed
the
diagnostics_logfiles
branch
from
September 25, 2026 10:58
86688bd to
e11a37d
Compare
Signed-off-by: Esther Gallego Estevez <ester.g.estevez@gmail.com>
ter04
force-pushed
the
diagnostics_logfiles
branch
from
September 25, 2026 11:50
e11a37d to
2b4a1ed
Compare
drugilsberg
requested changes
Sep 28, 2026
…CLI command --sqd_method and README information about the new CLI parameters Signed-off-by: Esther Gallego Estevez <ester.g.estevez@gmail.com>
Signed-off-by: Esther Gallego Estevez <ester.g.estevez@gmail.com>
ter04
force-pushed
the
diagnostics_logfiles
branch
from
September 28, 2026 09:10
0070254 to
689b087
Compare
Collaborator
Author
|
Force-pushed this branch to add a missing Signed-off-by line (DCO). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.