UID2 minor edits#1018
Conversation
sunnywu
left a comment
sunnywu
left a comment
There was a problem hiding this comment.
Documentation cleanup looks good overall — title renames, link fix, and Operator casing are consistently applied across English and Japanese mirrors. Flagging a few small inconsistencies where the rename was applied incompletely.
| title: UID2 Client-Server Integration Guide for Prebid.js | ||
| title: Client-Server Integration Guide for Prebid.js | ||
| sidebar_label: Client-Server Integration for Prebid.js | ||
| pagination_label: UID2 Client-Server Integration for Prebid.js |
There was a problem hiding this comment.
Claude Review: pagination_label still says UID2 Client-Server Integration for Prebid.js, even though title was just updated to drop the UID2 prefix. The sibling file integration-prebid-client-side.md updated both — looks like an oversight here. Same issue in the Japanese mirror at i18n/ja/docusaurus-plugin-content-docs/current/guides/integration-prebid-client-server.md.
There was a problem hiding this comment.
Done, 2 instances, thx.
| ### Latest Identity Map Endpoint (v3) | ||
| ### Latest POST /v3/identity/map Endpoint | ||
|
|
||
| In the latest identity map integration, you only need to call one endpoint, `POST /identity/map`. The `POST /identity/buckets` endpoint is not part of the workflow. |
There was a problem hiding this comment.
Claude Review: Heading on line 41 was just updated to Latest POST /v3/identity/map Endpoint, but this body sentence still refers to one endpoint, `POST /identity/map` . Reads inconsistently — consider matching the heading by writing POST /v3/identity/map here too. Same hunk in i18n/ja/docusaurus-plugin-content-docs/current/endpoints/summary-endpoints.md.
There was a problem hiding this comment.
Done. Japanese doesn't entirely match until the translator does his pass.
sunnywu
left a comment
sunnywu
left a comment
There was a problem hiding this comment.
Follow-up: two more spots where the UID2-prefix removal is applied asymmetrically. Also flagging an anchor-rendering verification ask: the new headings like ## Migration from POST /v2/identity/map rely on the default github-slugger producing migration-from-post-v2identitymap (slashes stripped). Worth doing a local yarn build to confirm none of the new in-page anchors silently 404.
| @@ -456,8 +456,8 @@ May 17, 2024 | |||
| We've added the following integration guides to support publishers who want to implement UID2 for their Android or iOS mobile apps: | |||
|
|
|||
| - [UID2 Mobile Integration Overview for Android and iOS](../guides/integration-mobile-overview) | |||
There was a problem hiding this comment.
Claude Review: This historical entry's link text still says [UID2 Mobile Integration Overview for Android and iOS], but integration-mobile-overview.md's actual title was changed in this same PR to drop the UID2 prefix. The PR did rewrite other historical references (e.g., Identity Map v3 → POST /v3/identity/map heading earlier in this same file), so the policy is inconsistent — either keep historical link text frozen, or update it to match current titles. Same instance in i18n/ja/.../ref-info/updates-doc.md.
There was a problem hiding this comment.
Made all consistent without the UID2.
sunnywu
left a comment
sunnywu
left a comment
There was a problem hiding this comment.
Third pass — two more sibling-heading inconsistencies inside files this PR already modifies. Plus one scope question: UID2 Mobile Integration Overview for Android and iOS was renamed to drop the UID2 prefix in this PR, but the sibling overview titles UID2 Integration Overview for Prebid and UID2 Integration Overview for JavaScript still keep the prefix. Worth confirming whether the mobile-overview rename was intentional in isolation (matching EUID #406 exactly) or whether the JS/Prebid overviews should follow.
| The following instructions provide an example of how to map DII to raw UID2s using the latest version of the `POST /identity/map` endpoint. | ||
|
|
||
| For the earlier version, see [Previous SDK Version (using POST /identity/map v2)](#previous-sdk-version-using-post-identitymap-v2). For migration steps to the latest version, see [Migration From Version Using v2 Identity Map](#migration-from-version-using-v2-identity-map). | ||
| For the earlier version, see [Previous SDK Version (using POST /v2/identity/map)](#previous-sdk-version-using-post-v2identitymap). For migration steps to the latest version, see [Migration From Version Using v2 Identity Map](#migration-from-version-using-v2-identity-map). |
There was a problem hiding this comment.
Claude Review: This link's anchor was updated to the new style (#previous-sdk-version-using-post-v2identitymap), but the second link in this same sentence still points at #migration-from-version-using-v2-identity-map — and the corresponding heading at line 389, ## Migration From Version Using v2 Identity Map, was not renamed. By contrast, the analogous heading in post-identity-map.md was renamed from ## Migration from v2 Identity Map → ## Migration from POST /v2/identity/map in this PR. Either rename this heading (and its inbound link on line 494) for consistency, or leave the endpoint-doc rename matching this style. The same unrenamed heading also exists in docs/sdks/sdk-ref-python.md (file untouched by this PR) and both JA mirrors.
There was a problem hiding this comment.
Agreed. Updated.
sunnywu
left a comment
sunnywu
left a comment
There was a problem hiding this comment.
Fourth pass — found one real bug (the rename was applied to the H1 but the frontmatter title field was missed). After this, I'm done — the rest of the PR is internally consistent.
sunnywu
left a comment
sunnywu
left a comment
There was a problem hiding this comment.
Doc-only PR aligning UID2 docs with EUID PR #406/#411: drops the UID2 prefix from many guide titles/links, renames v2 identity map style references to POST /v2/identity/map (and v3 equivalents), and standardises Private Operator / Public Operator capitalisation. Spot-checked anchor slugs (e.g. #migration-from-post-v2identitymap, #using-post-v2identitymap, #previous-sdk-version-using-post-v2identitymap) and they correctly match the slugifier rules for the renamed headings. The link-target fix in gs-permissions.md (v2 row now points to post-identity-map-v2.md instead of post-identity-map.md) is a nice catch. Two small consistency observations inline — both minor, neither blocking.
| The following instructions provide an example of how to map DII to raw UID2s using the latest version of the `POST /identity/map` endpoint. | ||
|
|
||
| For the earlier version, see [Previous Version (v2 Identity Map)](#previous-version-v2-identity-map). For migration steps to the latest version, see [Migration From Version Using v2 Identity Map](#migration-from-version-using-v2-identity-map). | ||
| For the earlier version, see [Previous Version (v2 Identity Map)](#previous-version-v2-identity-map). For migration steps to the latest version, see [Migration From Version Using POST /v2/identity/map](#migration-from-version-using-post-v2identitymap). |
There was a problem hiding this comment.
Claude Review: Within this single sentence the second link was renamed (Migration From Version Using v2 Identity Map → Migration From Version Using POST /v2/identity/map) but the first link (Previous Version (v2 Identity Map)) was left in the old style — and the heading it points to at line 400 (### Previous Version (v2 Identity Map)) is also unchanged. Compare with docs/sdks/sdk-ref-java.md:303, where the analogous sentence renamed both references and the ## Previous SDK Version (using POST /v2/identity/map) heading at line 490 was updated to match. Worth applying the same rename here (line 400 heading + this link text + the link at line 407) so the Java and Python SDK pages stay in sync. Same in the JA copy.
There was a problem hiding this comment.
Updated to:
Previous SDK Version (using POST /v2/identity/map)
| The following instructions provide an example of how to map DII to raw UID2s using the latest version of the `POST /identity/map` endpoint. | ||
|
|
||
| For the earlier version, see [Previous Version (v2 Identity Map)](#previous-version-v2-identity-map). For migration steps to the latest version, see [Migration From Version Using POST /v2/identity/map](#migration-from-version-using-post-v2identitymap). | ||
| For the earlier version, see [Previous Version (POST /v2/Identity Map)](#previous-version-post-v2identity-map). For migration steps to the latest version, see [Migration From Version Using POST /v2/identity/map](#migration-from-version-using-post-v2identitymap). |
There was a problem hiding this comment.
previous-version-post-v2identity-map
are you sure no dash between v2identity?
There was a problem hiding this comment.
@sunnywu you're amazing TYSM.
I checked before and after my fix and there were no broken links. But you spotted accurately and the reason why was the destination anchor tag was actually formatted POST /v2/Identity Map which is not correct.
Updated the copy, and the anchor with it, in both languages:
Previous Version (POST /v2/identity/map)
There are no other instances of this construction. And there are no broken links.
2 participants
To match mods made in EUID PR #406 and also a few extras in EUID PR #411.