Skip to content

chore: снять ветку up — сервис test есть во всех образах #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fey wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: снять ветку up — сервис test есть во всех образах #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 5 additions & 19 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,26 +151,12 @@ const check = async ({ projectSourcePath, codePath, projectMember }) => {
// NOTE: The verdict is the exit code of the test service. up would report the
// exit code of whichever container stopped first, so app and db shut down
// after successful tests turned a green run red.
//
// The service is not in every project image yet, so the step falls back to up.
// Without the fallback the merge would be a flag day: run --rm test on a
// project without the service exits 1, and "no such service" is
// indistinguishable from failing tests. The up branch goes away once every
// published image carries test. Mirrors hexlet-project-source-ci's template.
const { stdout: serviceList } = await exec.getExecOutput(
'docker compose',
[...composeFile, 'config', '--services'],
options,
);
const hasTestService = serviceList
.split('\n')
.map((name) => name.trim())
.includes('test');
const verdictArgs = hasTestService
? [...composeFile, 'run', '--rm', 'test']
: [...composeFile, 'up', '--abort-on-container-exit'];
try {
await exec.exec('docker compose', verdictArgs, options);
await exec.exec(
'docker compose',
[...composeFile, 'run', '--rm', 'test'],
options,
);
} catch (err) {
// NOTE: run attaches to the test container only, so logs of the services it
// waited for are the only clue left for a failing server project.
Expand Down