Add slot and base_power to item attributes#2
Open
Heckfer wants to merge 2 commits into
Open
Conversation
Parses the Infobox_Object `slot` (equipment slot for wearables) and `basepower` (rune base power) template parameters into the item_attribute table. Closes #1 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1 (ported from Heckfer/almanac-tibia#157).
What
Adds two
Infobox_Objecttemplate parameters toItemParser.item_attributes, so they are stored in theitem_attributetable during generation:slotslotNeck(Ruby Necklace)base_powerbasepower150(Sudden Death Rune)The other two fields from the original issue were already covered:
secondarytypeis thetype_secondarycolumn onitem, andregensecondsis thefood_timeitem attribute.Tests
Two new parser tests with fixtures taken from the live wiki articles (Ruby Necklace, Sudden Death Rune). Full suite passes (61 tests, 18 skipped as usual). Ruff findings in touched files are pre-existing and untouched.
🤖 Generated with Claude Code