fix(visualize): accept trailing prose after Chart.js JSON - #686
Open
santhreal wants to merge 6 commits into
Open
fix(visualize): accept trailing prose after Chart.js JSON#686santhreal wants to merge 6 commits into
santhreal wants to merge 6 commits into
Conversation
Local chartjs validation used json.loads on the whole payload, so a valid config followed by model prose failed and forced an unnecessary repair pass.
…-raw-decode # Conflicts: # deeptutor/skills/builtin/pdf/SKILL.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validate_visualization used json.loads on Chart.js payloads, so a valid object followed by trailing prose failed local checks.
Decode with JSONDecoder.raw_decode so the first object is accepted.