You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Monorepo] Decide where a definition of done lives for PRs #1124
.github/pull_request_template.md has Summary, Changes proposed, Context for reviewers, and Additional information. There is no definition of done checklist, so nothing prompts an author to confirm tests, docs, or a changeset before review.
The open question is whether the PR template is the right home for this. Each section of the repo has a different set of things that need to be done as part of a PR, so a single universal checklist may not work. Alternatives worth considering include per-area checklists, CODEOWNERS-driven guidance, or automated checks that enforce the same things without relying on the author.
Open questions
Is a universal definition of done achievable across the repo's sections, or does it need to vary by area?
Is the PR template the right place, or is this better handled by automation or per-area docs?
Which items genuinely need author confirmation versus a CI check?
Acceptance criteria
A recommendation is recorded on this ticket and agreed with the team
The agreed approach is implemented and renders or runs correctly on a new PR
Activity