Skip to content

fix(GAT-8925): Fix incorrect config read on cohort expiry command#1692

Merged
equinoxmatt merged 2 commits into
devfrom
fix/GAT-9136
Jul 2, 2026
Merged

fix(GAT-8925): Fix incorrect config read on cohort expiry command#1692
equinoxmatt merged 2 commits into
devfrom
fix/GAT-9136

Conversation

@equinoxmatt

Copy link
Copy Markdown
Contributor

Describe your changes

The wrong config value was being used when calculating the expiry date for nhse sde.

Also created a test to cover the nhse sde approval on PUT /api/v1/cohort_requests/{id}

Issue ticket link

https://hdruk.atlassian.net/browse/GAT-8925

Environment / Configuration changes (if applicable)

Requires migrations being run?

If not using the pre-push hook. Confirm tests pass:

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added appropriate unit tests
  • I have created mocks for unit tests (where appropriate)
  • I have added appropriate Behat tests to confirm AC (if applicable)
  • I have added Swagger annotations for new endpoints (if applicable)
  • I have added audit logs for new operation logic (if applicable)
  • I have added new environment variables to the .env.example file (if applicable)
  • I have added new environment variables to terraform repository (if applicable)

@equinoxmatt equinoxmatt requested a review from a team as a code owner July 2, 2026 14:34
@gh-actions-pipelines-app

Copy link
Copy Markdown

🎉 Great job! Your PR title follows the correct format. 🚀

@equinoxmatt equinoxmatt merged commit ecedbfc into dev Jul 2, 2026
4 checks passed
@equinoxmatt equinoxmatt deleted the fix/GAT-9136 branch July 2, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants