Repository navigation
Honor Clean Support option in packaging - #8
Merged
Merged
Conversation
Fix bug where the "Clean Support Directory" checkbox was ignored during batch packaging (Package All / Package Selected). app.py now uses support_clean_input.isChecked() for the clean_support flag instead of referencing clean_support_checkbox, ensuring the setting is respected. Updated CHANGELOG to document the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue where the "Clean Support Directory" checkbox was being ignored during packaging operations. The logic for determining whether to clean the support directory has been corrected to use the appropriate checkbox state.
Bug fix for batch packaging:
_packageBuildsmethod inapp.pyto use the correct checkbox (support_clean_input) for the "Clean Support Directory" option during batch packaging operations, ensuring user preference is respected.