Check only the most recent commit message #53

Activity

1. gilbertsoft commented on Feb 24, 2022

   

   gilbertsoft

   on Feb 24, 2022

   Member

   More actions

   In the first place I'd suggest to create a dedicated test action instead. For me it looks you mix up various jobs here which I really would not suggest to do.

   Have a look at my workflows here, there is a clear separation of CI and pull request handling https://github.com/GsTYPO3/core-patches/tree/main/.github/workflows

   PR related action: https://github.com/GsTYPO3/core-patches/actions/runs/1818090001
   CI related action: https://github.com/GsTYPO3/core-patches/actions/runs/1818090153
2. gilbertsoft

   added

   questionFurther information is requestedFurther information is requested

   on Feb 25, 2022
3. bbchase commented on Feb 28, 2022

   

   bbchase

   on Feb 28, 2022

   Author

   More actions

   The test I'm referring to is run in local dev environment and devs paste the result into their commit. We want to use this check to make sure that the most-recent commit has passed this test before approving the PR.
4. gilbertsoft commented on Mar 2, 2022

   

   gilbertsoft

   on Mar 2, 2022

   Last edited by gilbertsoft

   Member

   More actions

   @bbchase You should try it by set excludeDescription, excludeTitle and checkAllCommitMessages to true. This should work for your case I'd say. Then check the end of the message.

   See also https://github.com/GsActions/commit-message-checker#configuration.
5. bbchase commented on Mar 2, 2022

   

   bbchase

   on Mar 2, 2022

   Author

   More actions

   I have tried that. In that case, all commits associated with a PR are checked and if any commit does not contain the test message for whatever reason, the check will fail. I really only care that the latest commit contains this message.

   Here's the contents of the yml file if it helps:

   name: 'Commit Message Check'
   on:
     pull_request:
       types:
         - opened
         - edited
         - reopened
         - synchronize
     pull_request_target:
       types:
         - opened
         - edited
         - reopened
         - synchronize
     push:
       branches:
         - main
   
   jobs:
     check-commit-message:
       name: Look for Test Suite message
       runs-on: ubuntu-latest
       steps:
         - name: Check Commit Type
           uses: gsactions/commit-message-checker@v1
           with:
             pattern: '^Successful Full Test Suite Run at \d\d\d\d+-\d\d-\d\d \d\d:\d\d:\d\d UTC$'
             error: 'The commit message must include a successful full test suite run.'
             excludeTitle: true
             excludeDescription: true
             checkAllCommitMessages: true
             accessToken: ${{ secrets.GITHUB_TOKEN }}
6. gilbertsoft commented on Mar 6, 2022

   

   gilbertsoft

   on Mar 6, 2022

   Last edited by gilbertsoft

   Member

   More actions

   The problem here is your pattern, which tests for the start. Try this one Successful Full Test Suite Run at \d\d\d\d+-\d\d-\d\d \d\d:\d\d:\d\d UTC$ which will only take care about the end.

   If this does still not work, enable debugging see https://docs.github.com/en/actions/monitoring-and-troubleshooting-workflows/enabling-debug-logging. Then you will see the message which is built and you can use tools like https://regexr.com/ afterwards to find a working pattern.

   And if you enforce pull request, it does not make much sense to run the action for the main branch btw.
7. gilbertsoft

   changed the title [-][Feature Request] Option to check only the most recent commit message[/-] [+]Check only the most recent commit message[/+] on Mar 6, 2022
8. GsActions

   locked and limited conversation to collaborators on Mar 6, 2022
9. gilbertsoft

   converted this issue into a discussion #61 on Mar 6, 2022